Separate transit IPs by version in the database #9542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #9389 that I missed. We were already separating transit IPs by version in the code before and after the database. This pushes that separation all the way into the database, which will make it easier to implement updates to dual-stack NICs in the public API. Separating them lets clients update the transit IPs for only one version, without some janky read-modify-write code that ensures we don't clobber the transit IPs for the _other_ version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #9389 that I missed. We were already separating transit IPs by version in the code before and after the database. This pushes that separation all the way into the database, which will make it easier to implement updates to dual-stack NICs in the public API. Separating them lets clients update the transit IPs for only one version, without some janky read-modify-write code that ensures we don't clobber the transit IPs for the other version.