TQ: Plumb initial configuration through handoff #9576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that when trust quorum is enabled the initial configuration gets passed up through the handoff to Nexus and put in CRDB. It was tested in a4x2 with `TRUST_QUORUM_INTEGRATION_ENABLED=true`, a small [fix](oxidecomputer/testbed#236) for a4x2, and a fix in this PR to plumb through the correct sp-sim model number so that handoff works correctly in a4x2. This PR should have no impact on main, as `TRUST_QUORUM_INTEGRATION_ENABLED` remains set to `false`.
andrewjstone
force-pushed
the
tq-nexus-api
branch
from
1681df1 to
602ff02
Compare
emilyalbini
approved these changes
Jan 7, 2026
Member
emilyalbini
left a comment
emilyalbini
left a comment
There was a problem hiding this comment.
This is indeed mostly plumbing, I confirmed that the only non-plumbing thing seems correct (see review comment).
|
|
||
| Some(InitialTrustQuorumConfig { | ||
| members: tq_members.into_iter().collect(), | ||
| coordinator: trust_quorum.baseboard_id().clone(), |
Member
There was a problem hiding this comment.
Using the current node as the coordinator is correct, init_trust_quorum assumes the current node is the coordinator as well.
Contributor
Author
|
Thanks for the review @pietroalbini! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that when trust quorum is enabled the initial configuration gets passed up through the handoff to Nexus and put in CRDB.
It was tested in a4x2 with
TRUST_QUORUM_INTEGRATION_ENABLED=true, a small fix for a4x2, and a fix in this PR to plumb through the correct sp-sim model number so that handoff works correctly in a4x2.This PR should have no impact on main, as
TRUST_QUORUM_INTEGRATION_ENABLEDremains set tofalse.