[fix, mcast] update mcast public docs formatting #9623
Conversation
zeeshanlakhani
force-pushed
the
zl/fix-mcast-fmt-docs
branch
from
954ee6a to
8994f50
Compare
|
This keeps the newlines, but not the list matter. |
| // | date-based version should be at the top of the list. | ||
| // v | ||
| // (next_yyyymmddnn, IDENT), | ||
| (2026011100, MULTICAST_JOIN_LEAVE_DOCS), |
There was a problem hiding this comment.
is a new version required? @sunshowers I thought a trivial change would be ... fine? or is that more of a future? thanks!
There was a problem hiding this comment.
From what I can tell, cargo xtask openapi generate doesn't pick up doc changes (even on non-versioned delegation changes), unless the version is bumped. Not sure if there's a way around this using the xtask and our blessed version approach.
There was a problem hiding this comment.
Yes, you need to force a version bump in this situation, because we treat blessed versions as immutable. (Either the current or an upcoming dropshot-api-manager will force you to make a bump in this situation.)
BTW RFD 634 was written in part so that people don't feel bad about adding new versions (and seeing a 30k line diff or similar)
There was a problem hiding this comment.
BTW RFD 634 was written in part so that people don't feel bad about adding new versions (and seeing a 30k line diff or similar)
Right. Trying not to feel bad (as I've been doing it alot :)).
There was a problem hiding this comment.
Thank you. Don't we get paid based on LOC?
|
@david-crespo @ahl any other spots in the CLI generation I should fix? |
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
this is great thanks a ton for doing it!
Simplifies and better formats mcast member joining/leaving docs.