Skip to content

Conversation

@sudomateo
Copy link
Collaborator

Added a CODEOWNERS file.

@sudomateo sudomateo merged commit 83ef11f into main Jul 1, 2025
1 check passed
@sudomateo sudomateo deleted the push-luqvsqppnzuv branch July 1, 2025 23:34
@karencfv
Copy link
Collaborator

karencfv commented Jul 7, 2025

Not against this change at all! Just wondering why we'd want a codeowners file in this repo? The TF provider needs if for security reasons due to the GPG key signing process https://rfd.shared.oxide.computer/rfd/0394, but for the Go SDK we don't really have that requirement.

@sudomateo
Copy link
Collaborator Author

Not against this change at all! Just wondering why we'd want a codeowners file in this repo? The TF provider needs if for security reasons due to the GPG key signing process https://rfd.shared.oxide.computer/rfd/0394, but for the Go SDK we don't really have that requirement.

I added it so that we'd get assigned as reviewers for pull requests and the pull requests would show up in the https://github.com/pulls view under "Review requests". That way they don't get hidden in the GitHub inbox view. I'm happy to remove it though since we're generally the only ones that commit to this repository outside of dependabot.

@karencfv
Copy link
Collaborator

karencfv commented Jul 7, 2025

Thanks!

I'm happy to remove it though since we're generally the only ones that commit to this repository outside of dependabot.

Nah, it's OK, let's leave it. Was mostly just curious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants