auth: prompt the user to open the browser #418
Conversation
|
Sorry for the delay on this. Looks good: any thoughts on how we might add a test? |
No worries! I can add a unit test to I see there are tests in |
|
Give it a shot? if nothing seems to work well then we'll merge as-is. Thanks again! |
Will do! Busy week this week but I'll work on it sometime next week. I'll ping here when updated. |
sudomateo
force-pushed
the
sudomateo/auth-login-updates
branch
from
957e117
to
1f08cd0
Compare
sudomateo
changed the title
|
Sorry for the delay on this. I finally got some time to work on this. I refactored the function to be generic and added unit tests. If there's time tomorrow I'll take a look at adding an integration test that actually runs |
|
I added integration tests. This is ready for another review. There might be a need to update how the |
Previously the `oxide auth login` command would automatically open the user's browser which can be a jarring user experience. This patch updates `oxide auth login` to prompt the user to open the browser instead of just opening the browser automatically. Users passing `--no-browser` will not receive this prompt and will instead have the URL printed to standard output. Closes: oxidecomputer#88
sudomateo
force-pushed
the
sudomateo/auth-login-updates
branch
from
0627e10
to
8bf8446
Compare
|
Rebased and updated the branch. |
Previously the
oxide auth logincommand would automatically open theuser's browser which can be a jarring user experience.
This patch updates
oxide auth loginto prompt the user to open thebrowser instead of just opening the browser automatically. Users passing
--no-browserwill not receive this prompt and will instead have theURL printed to standard output.
Closes: #88