Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for const pointers to integer types #56

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Conversation

bnaecker
Copy link
Collaborator

@bnaecker bnaecker commented Apr 1, 2022

  • Reworks some of the internal dtrace-parser code to make integers more
    compact and easily represent pointers.
  • Adds support for pointers the implementation crates
  • Adds pointers to list of supported types
  • Adds a probe in the probe-test-attr crate that uses a pointer.

- Reworks some of the internal dtrace-parser code to make integers more
  compact and easily represent pointers.
- Adds support for pointers the implementation crates
- Adds pointers to list of supported types
- Adds a probe in the `probe-test-attr` crate that uses a pointer.
@bnaecker bnaecker requested review from ahl and jgallagher April 1, 2022 19:35
Copy link

@jgallagher jgallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried it with on MGS locally and worked perfectly.

dtrace-parser/src/dtrace.pest Outdated Show resolved Hide resolved
usdt-attr-macro/src/lib.rs Show resolved Hide resolved
usdt-attr-macro/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@ahl ahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get that money!

README.md Outdated Show resolved Hide resolved
dtrace-parser/src/dtrace.pest Outdated Show resolved Hide resolved
usdt/src/lib.rs Show resolved Hide resolved
@bnaecker bnaecker requested review from ahl and jgallagher April 4, 2022 19:36
@bnaecker bnaecker merged commit c32ec7a into master Apr 5, 2022
@bnaecker bnaecker deleted the pointer-support branch April 5, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants