Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Ruby 3.3 version must be 3.3.5 #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gjtorikian
Copy link
Contributor

The precompiled gem for Commonmarker disappeared after I updated build dependencies to support Ruby 3.4: gjtorikian/commonmarker#333

Digging into it, I found this little note in rake-compiler-dock:

Update Ruby 3.3 support from 3.3.0-rc1 to 3.3.5. Note that the 3.3.x releases are not usable until 3.3.5 because of https://bugs.ruby-lang.org/issues/20088.

Note that if you were specifying 3.3.0 in your RUBY_CC_VERSION environment variable, that string must be updated to 3.3.5.

@gjtorikian
Copy link
Contributor Author

It's tremendously unclear why 1.65 is failing here. 🫨

@jbourassa
Copy link
Contributor

jbourassa commented Jan 2, 2025

It's tremendously unclear why 1.65 is failing here. 🫨

I think it's failing because the test extension's Cargo.lock uses version 4 which the old rust does not know about. It was updated in the most recent release (see this git blame).

Maybe we can manually revert to v3 by running cargo generate-lockfile on an older rust and somehow force dependabot to also use an older rust? Edit: dependabot wasn't the issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants