Give email services distinct names #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronerben
force-pushed
the
bugfix/multi-email
branch
from
9c373ac to
ae21202
Compare
joseferben
reviewed
Aug 10, 2021
joseferben
reviewed
Aug 10, 2021
joseferben
reviewed
Aug 10, 2021
aronerben
force-pushed
the
bugfix/multi-email
branch
from
ae21202 to
a174477
Compare
|
@Jerben Tests are missing, but what do you think of this solution? |
joseferben
reviewed
Aug 13, 2021
|
@aronerben Good solution, I don't see why it wouldn't work. |
aronerben
force-pushed
the
bugfix/multi-email
branch
from
a174477 to
5b3ba54
Compare
|
Don't merge yet, I want to add more tests |
aronerben
force-pushed
the
bugfix/multi-email
branch
from
bd1fae5 to
809c2aa
Compare
Starting services with equal names causes problems when sorting dependencies. Rework lifecycles, services and add id. Clean up some small code parts and fix tests.
aronerben
force-pushed
the
bugfix/multi-email
branch
from
809c2aa to
d571c2c
Compare
joseferben
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting services with equal names causes problems when sorting
depedencies. Name them differently. Clean up some small code parts.