Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels of various plugin settings #6

Closed
MattBlair01 opened this issue Jan 20, 2017 · 5 comments
Closed

Update labels of various plugin settings #6

MattBlair01 opened this issue Jan 20, 2017 · 5 comments
Assignees

Comments

@MattBlair01
Copy link
Collaborator

MattBlair01 commented Jan 20, 2017

image

  • please remove '(Do not adjust unless instructed to by Oxipay staff)' from 'Gateway URL' description

  • please change 'Gateway URL Sanbox' to 'Test Gateway URL'

  • please change 'Merchant Number' to 'Merchant ID'

@sam-flexi
Copy link
Collaborator

Hi,

Looks good, the only issue outstanding is the Merchant Number, please change this to Merchant ID.

@sam-flexi
Copy link
Collaborator

Thanks, I can see it now as Merchant ID. However, I've noticed that the value in Merchant ID is masked. Are we able to change it so that it is visible. The only value that needs to be masked is the API Key.

image

@sam-flexi sam-flexi changed the title Plugin option description changes required. Update labels of various plugin settings Mar 8, 2017
iugo-josh added a commit that referenced this issue Mar 8, 2017
Addresses feedback in issue #6
@iugo-josh
Copy link
Contributor

I've added a commit to PR #21 that will change the Merchant ID to a plain text field.

You may need to clear out the cache for this to appear in the admin.

An existing value in the field may appear strangely at first, as the old field type was encrypting the value in this field. Saving a new merchant ID in plain text will fix this.

@sam-flexi
Copy link
Collaborator

Have tested this on a fresh bitnami/magento image and the issue is still ocuring. Have also cleared the browser's cache and also flushed Magento's cache and yeah, the Merchant ID is still masked.

Will move this issue into the backlog column.

@sam-flexi
Copy link
Collaborator

In the second PR that was submitted, the issue is resolved and I can see that the merchant ID is no longer masked.
Closing this issue off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants