Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add consume_file #10

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

WIP: add consume_file #10

wants to merge 8 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 4, 2024

This PR:

  • adds needletail for parsing FASTA/Q files
  • factors out a new internal method consume_bytes
  • adds method consume_file

@Adamtaranto
Copy link
Collaborator

Merged in main and commented out some unused imports.

Tests failing on consume bad DNA. Wrong error type returned, I think.

@Adamtaranto
Copy link
Collaborator

Merged in new main. Build fails on unspecified liblzma-sys version conflict between liblzma and niffler.
Leaving as is for now.

@Adamtaranto
Copy link
Collaborator

Merged main, added libzma-sys.

Unresolved dep clash between needletail and xz2?

@Adamtaranto
Copy link
Collaborator

@ctb can you please resolve the conflict between consume() in main and your new consume_bytes() function so that yours also supports the new store_kmers option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants