-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sourmash from 0.17.2 to 0.18.0 #104
base: main
Are you sure you want to change the base?
Conversation
7f32c75
to
ab8dc86
Compare
Bumps [sourmash](https://github.com/sourmash-bio/sourmash) from 0.17.2 to 0.18.0. - [Release notes](https://github.com/sourmash-bio/sourmash/releases) - [Changelog](https://github.com/sourmash-bio/sourmash/blob/latest/doc/release.md) - [Commits](sourmash-bio/sourmash@r0.17.2...r0.18.0) --- updated-dependencies: - dependency-name: sourmash dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
ab8dc86
to
2759e7f
Compare
This is gonna break 😆 We've added skipmers to sourmash, and I feel like there's an interesting opportunity here to take advantage of that in oxli, as well as maybe add other k-mer types... I hope to work on this over the next few weeks. |
A newer version of sourmash exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
@ctb will the new sourmash version fix compatibility issues here or do we need to edit oxli? |
@ctb fixed the orcid issue, but it looks like you've changed the output of Can you please fix this one? |
@ctb I've had a go at dealing with the new SeqToHashes Result object. It builds and passes tests, but I don't think I have handled the second half of the Result object correctly, assuming that is supposed to pass errors from Sourmash. |
Bumps sourmash from 0.17.2 to 0.18.0.
Release notes
Sourced from sourmash's releases.
Commits
2325d8d
MRG: update rust CHANGELOG in preparation for r0.18.0 (#3450)150967b
MRG: add skipmer capacity to sourmash python layer via ffi (#3446)419eb73
Bump thiserror from 2.0.7 to 2.0.8 (#3448)5680efc
MRG: add skipmers; switch to reading frame approach for translation, skipmers...b69c960
Refactor: Use to_writer/from_reader across the codebase (#3443)f4f5187
MRG: adjustSignature::name()
to returnOption\<String>
instead of `filena...635ffc1
Bump thiserror from 2.0.6 to 2.0.7 (#3435)a148a64
Bump proptest from 1.5.0 to 1.6.0 (#3437)8a9ae58
Bump roaring from 0.10.8 to 0.10.9 (#3438)61be936
Bump serde from 1.0.215 to 1.0.216 (#3436)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)