Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Comments reporter - Change status when all tests pass #1915

Closed
TommyE123 opened this issue Sep 28, 2022 · 4 comments · Fixed by #1920
Closed

Azure Comments reporter - Change status when all tests pass #1915

TommyE123 opened this issue Sep 28, 2022 · 4 comments · Fixed by #1920
Labels
enhancement New feature or request

Comments

@TommyE123
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Thank you so much for implementing the Azure Comments reporter which we are now using on our PR’s in devops.

Would it be possible though to set the status of the comment to something other than ‘Active’ when the all the tests pass? If like we do, you have your build policies set to having to resolve all comments this can become quite annoying when most of the time the Linters are passing!

Describe the solution you'd like
We’ve currently been manually setting the comment to Resolved however I’m open to setting it to something else if you feel appropriate?
Possibly ‘Bydesign = 5’ for when all the tests pass?
(however, that’s not a selectable option on the manual dropdown so we'd have to test that it works!)

I think the below thread lists the possible status options we can choose from?
CommentThreadStatus enum | Microsoft Learn

Describe alternatives you've considered
Make it a configurable option to do this if you would rather not set it to Bydesign or Resolved by default so users can have the choice maybe?

Additional context
N/A

Thanks again
Tom

@TommyE123 TommyE123 added the enhancement New feature or request label Sep 28, 2022
@nvuillam
Copy link
Member

@TommyE123 thanks for your nice feedback:)
I'm not a regular user of azure pipelines, I didn't know there was a status for comment :)
The API probably allows to send a status so in case there is no error, ok to set it as resolved :)

You can even make the pull request if you want :)

@nvuillam
Copy link
Member

nvuillam commented Oct 1, 2022

@TommyE123 this is done :)
It will be available in the next release, and if you are in a hurry you can already use it with oxsecurity/megalinter:beta :)

@TommyE123
Copy link
Contributor Author

@nvuillam Thanks for making this change.
I've done a simple test of this in the beta branch and its working as expected 👍

Cheers
Tom

@nvuillam
Copy link
Member

nvuillam commented Oct 5, 2022

@TommyE123 thanks for your test and feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants