Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylint: Unrecognized option found: no-space-check #1923

Closed
schorlton opened this issue Oct 2, 2022 · 8 comments · Fixed by #1924
Closed

Pylint: Unrecognized option found: no-space-check #1923

schorlton opened this issue Oct 2, 2022 · 8 comments · Fixed by #1924
Assignees
Labels
bug Something isn't working

Comments

@schorlton
Copy link
Contributor

Running oxsecurity/megalinter-python:v6.11.0 off docker. Hitting:

❌ Linted [PYTHON] files with [pylint]: Found 3 error(s) - (6.65s)
- Using [pylint v2.15.3] https://oxsecurity.github.io/megalinter/6.11.0/descriptors/python_pylint
- MegaLinter key: [PYTHON_PYLINT]
- Rules config: [.pylintrc]
- Number of files analyzed: [2]
--Error detail:
************* Module /action/lib/.automation/.pylintrc
/action/lib/.automation/.pylintrc:1:0: E0015: Unrecognized option found: no-space-check (unrecognized-option)

Thank you as always!!

@schorlton schorlton added the bug Something isn't working label Oct 2, 2022
@Kurt-von-Laven
Copy link
Collaborator

According to the Pylint 2.6 release notes:

The no-space-check option has been removed, it's no longer possible to consider empty line like a trailing-whitespace by using clever options.

@Kurt-von-Laven Kurt-von-Laven added invalid This doesn't seem right and removed bug Something isn't working labels Oct 2, 2022
@Kurt-von-Laven Kurt-von-Laven self-assigned this Oct 2, 2022
@schorlton
Copy link
Contributor Author

According to the Pylint 2.6 release notes:

The no-space-check option has been removed, it's no longer possible to consider empty line like a trailing-whitespace by using clever options.

Sure, but megalinter shouldn't error on this? I'm just using vanilla megalinter...this seems like a megalinter bug?

@nvuillam
Copy link
Member

nvuillam commented Oct 2, 2022

@Kurt-von-Laven as we deliver a default .pylintrc file, shouldn't we remove no-space-check from it ?

@Kurt-von-Laven Kurt-von-Laven reopened this Oct 2, 2022
@Kurt-von-Laven Kurt-von-Laven added bug Something isn't working and removed invalid This doesn't seem right labels Oct 2, 2022
@echoix
Copy link
Collaborator

echoix commented Oct 2, 2022

Maybe have a reminder of pylint's breaking change in the release notes for now, while a complete solution is made.

It might be useful for repos where they have a customized config file or customized .pylintrc file, which we shouldn't change.

@Kurt-von-Laven
Copy link
Collaborator

This specific issue seems like a one line fix? I personally don’t think MegaLinter ought to be in the business of “redocumenting” our dependencies. We already have this issue thread in this case, and someone with questions about linters that don’t pertain to MegaLinter directly is likely going to be better served by going directly to the source.

@echoix
Copy link
Collaborator

echoix commented Oct 2, 2022

I personally don’t think MegaLinter ought to be in the business of “redocumenting” our dependencies. We already have this issue thread in this case, and someone with questions about linters that don’t pertain to MegaLinter directly is likely going to be better served by going directly to the source.

Sorry, I might not have been following for long enough to remember that case, even if I am subscribed to all activity on this repo for a little while. Thanks for the feedback!

@nvuillam
Copy link
Member

nvuillam commented Oct 2, 2022

I think the ones that could play more fair is... pylint that does not respect SEMVER :)

SEMVER means Breaking change = major version , so their 2.6 should be a a 3.0 :)

@Kurt-von-Laven
Copy link
Collaborator

Sorry, I might not have been following for long enough to remember that case, even if I am subscribed to all activity on this repo for a little while. Thanks for the feedback!

Oh, I was merely referring to the thread we are currently having this discussion on. I think someone encountering the error in question who searches for no-space-check in conjunction with either Pylint or MegaLinter will find the answer they are looking for quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants