Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8r configuration file not working? #1974

Closed
bdovaz opened this issue Oct 17, 2022 · 13 comments
Closed

v8r configuration file not working? #1974

bdovaz opened this issue Oct 17, 2022 · 13 comments
Labels
enhancement New feature or request nostale This issue or pull request is not stale, keep it open

Comments

@bdovaz
Copy link
Collaborator

bdovaz commented Oct 17, 2022

This page describes how to create a configuration file for this linter: https://github.com/chris48s/v8r#configuration

In my case, I want to customize several schemas because in the repository there are several azure-pipelines*.yml or docker-compose*.yml files that not having the standard name, it does not take the schema and I want to indicate it.

When running megalinter it seems that it is as if this file does not exist.

@bdovaz bdovaz added the bug Something isn't working label Oct 17, 2022
@Kurt-von-Laven
Copy link
Collaborator

Usually, I would suggest adding YAML_V8R_CONFIG_FILE: LINTER_DEFAULT to your MegaLinter config, but the setting doesn’t appear to exist. Feel free to open a pull request to add this setting.

@Kurt-von-Laven Kurt-von-Laven added enhancement New feature or request and removed bug Something isn't working labels Oct 17, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 18, 2022

I have added the field in the descriptor, as I don't quite understand the whole flow in megalinter descriptors, seeing the link in my first post and how the configuration file resolution works in this linter, do you think something else is needed?

@nvuillam
Copy link
Member

@bdovaz config_file_name will make that cli_config_arg_name will be used if the file is found in

  • root folder of the repo
  • .github/linters
  • TEMPLATES (default config in megalinter)

cli_config_arg_name is -c by default, does v8r understand this arg ?

@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 18, 2022

@nvuillam According to this link: https://github.com/chris48s/v8r#configuration

It says that you don't need to pass any parameter and that it automatically looks for it in the working directory under the listed names and by default I have chosen ".v8rrc.yml" but that's why I don't understand what to do in this PR. This linter supposedly does not need to pass any parameter, it simply looks for files with those names in the working directory and that is what does not work with megalinter and it does if I run the linter outside on my own with the npm package, for example: v8r filetocheck.yml

@nvuillam
Copy link
Member

The problem is that the list of files is sent in absolute format, cwd is not the root of the repo.
I have a PR pending but there is still some bug so I can't merge it yet :/

@bdovaz
Copy link
Collaborator Author

bdovaz commented Oct 18, 2022

Ok, I'll wait then, can you mention here which one it is? To have it tracked

@nvuillam
Copy link
Member

@bdovaz this one
#1877

If you find why there is some strange stuff provoking timeout.... you're a MegaLinter hero ! :D ( I'm very busy at my actual job these days, I unfortunately have less time for open source :/ )

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 18, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Nov 18, 2022

Any news?

@nvuillam
Copy link
Member

We still need to make pass the PR that uses relative paths :/

@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 18, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 19, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 19, 2022

No stale, waiting for #1877

@Kurt-von-Laven Kurt-von-Laven added nostale This issue or pull request is not stale, keep it open and removed O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity labels Dec 19, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 10, 2025

It has been resolved long ago.

@bdovaz bdovaz closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nostale This issue or pull request is not stale, keep it open
Projects
None yet
Development

No branches or pull requests

3 participants