Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of configuration files with v8r #1982

Merged
merged 11 commits into from
Apr 20, 2023

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Oct 18, 2022

@bdovaz bdovaz requested a review from nvuillam as a code owner October 18, 2022 20:17
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 18, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Nov 18, 2022

Any news?

@nvuillam
Copy link
Member

We still need to make pass the PR that uses relative paths :/

@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 18, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 19, 2022
@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 19, 2022

No stale, waiting for #1877

@Kurt-von-Laven Kurt-von-Laven added nostale This issue or pull request is not stale, keep it open and removed O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity labels Dec 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #1982 (365baf2) into main (964fe7f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
+ Coverage   82.47%   82.50%   +0.02%     
==========================================
  Files         170      170              
  Lines        4469     4469              
==========================================
+ Hits         3686     3687       +1     
+ Misses        783      782       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdovaz
Copy link
Collaborator Author

bdovaz commented Apr 20, 2023

@nvuillam It could be merged already, couldn't it? Already been unlocked by #1877

@nvuillam
Copy link
Member

@bdovaz if the CI jobs are ok, yes:)

@nvuillam nvuillam merged commit 795da4f into oxsecurity:main Apr 20, 2023
@bdovaz bdovaz deleted the feature/v8r-configuration branch April 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nostale This issue or pull request is not stale, keep it open
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants