-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitlab comment reporter, misleading error message #2420
Comments
@LBeaulaton good catch , thanks :) Would you like to make a quick PR ? :) |
never done this, I can try |
@LBeaulaton contributing to open source is a great experience :) ( be careful, if you're like me, once you'll start you'll never stop :D ) https://megalinter.io/latest/contributing/#submitting-a-pull-request (as this is a very simple PR you may just fork, update the code and create a PR, no need to locally build ) |
* Resolves #2420 * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Nicolas Vuillamy <nicolas.vuillamy@gmail.com>
For gitlab CI, if the access token is badly defined (see the correct way: https://github.com/oxsecurity/megalinter#gitlab-ci), the following line asks for defining
GITLAB_MEGALINTER_ACCESS_TOKEN
while it should beGITLAB_ACCESS_TOKEN_MEGALINTER
megalinter/megalinter/reporters/GitlabCommentReporter.py
Line 169 in 5e7d9e3
Note also that in the readme you do not precise that the access token should have the appropriate role (when it is a project token and not a personal token like in the demo) to comment on a merge request (at least developer).
PS: thanks for your great job
The text was updated successfully, but these errors were encountered: