Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA fails new actionlint #2963

Closed
max-sixty opened this issue Sep 18, 2023 · 6 comments · Fixed by #3130
Closed

GHA fails new actionlint #2963

max-sixty opened this issue Sep 18, 2023 · 6 comments · Fixed by #3130
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity

Comments

@max-sixty
Copy link

Describe the bug

The suggested GHA workflow fails with the latest actionlint linter: https://results.pre-commit.ci/run/github/449091292/1695063235.7tYTqfzvS4asLD5xzP8zWg

I think I mentioned before — to the extent that megalinter could package up the action, rather than supply an 189-line file for folks to copy into their project, that would be a nice way of encapsulating it. With the existing setup, I'm guessing everyone will have to update the action themselves — not a great stress, but less elegant than a single central update.

Thank you!

@max-sixty max-sixty added the bug Something isn't working label Sep 18, 2023
@Kurt-von-Laven
Copy link
Collaborator

There is already an official MegaLinter action, but I don't see any issue with offering a callable workflow as well. Since you use pre-commit.ci, you may be interested in ScribeMD/pre-commit-action, which we use to run MegaLinter on GitHub Actions via pre-commit. It leverages asdf to keep your dev environment and CI pinned to the same versions of dev tools and some GitHub Actions features to setup and run pre-commit efficiently and reproducibly. On GitHub Actions, I suspect MegaLinter performs best when pulling the image from the GHCR (GitHub Container Registry) rather than the default of Docker Hub. mega-linter-runner takes an --image flag that can be used to change registries (e.g., npx mega-linter-runner --image ghcr.io/oxsecurity/megalinter-javascript:v7.3.0).

@max-sixty
Copy link
Author

There is already an official MegaLinter action, but I don't see any issue with offering a callable workflow as well.

Yes great, this is what I was thinking.


(though tbc, we can close this when the workflow passes the lint, the maintainers have much more context than I do on how they want folks to consume megalinter...)

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Oct 19, 2023
@max-sixty
Copy link
Author

I'm not sure if it's still an issue, though I'll leave it up to the maintainers to manage...

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Oct 20, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 19, 2023
@max-sixty
Copy link
Author

I'm not sure if it's still an issue, though I'll leave it up to the maintainers to manage...

nvuillam added a commit that referenced this issue Nov 19, 2023
nvuillam added a commit that referenced this issue Nov 19, 2023
Fixes #2963
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
nvuillam added a commit that referenced this issue Nov 19, 2023
Fixes #2963
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants