-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA fails new actionlint #2963
Comments
There is already an official MegaLinter action, but I don't see any issue with offering a callable workflow as well. Since you use pre-commit.ci, you may be interested in ScribeMD/pre-commit-action, which we use to run MegaLinter on GitHub Actions via pre-commit. It leverages asdf to keep your dev environment and CI pinned to the same versions of dev tools and some GitHub Actions features to setup and run pre-commit efficiently and reproducibly. On GitHub Actions, I suspect MegaLinter performs best when pulling the image from the GHCR (GitHub Container Registry) rather than the default of Docker Hub. mega-linter-runner takes an |
Yes great, this is what I was thinking. (though tbc, we can close this when the workflow passes the lint, the maintainers have much more context than I do on how they want folks to consume megalinter...) |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
I'm not sure if it's still an issue, though I'll leave it up to the maintainers to manage... |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the |
I'm not sure if it's still an issue, though I'll leave it up to the maintainers to manage... |
Fixes #2963 Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Fixes #2963 Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
Describe the bug
The suggested GHA workflow fails with the latest actionlint linter: https://results.pre-commit.ci/run/github/449091292/1695063235.7tYTqfzvS4asLD5xzP8zWg
I think I mentioned before — to the extent that megalinter could package up the action, rather than supply an 189-line file for folks to copy into their project, that would be a nice way of encapsulating it. With the existing setup, I'm guessing everyone will have to update the action themselves — not a great stress, but less elegant than a single central update.
Thank you!
The text was updated successfully, but these errors were encountered: