Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin Detekt cli_lint_mode= list_of_files support #3754

Closed
enciyo opened this issue Jul 9, 2024 · 2 comments · Fixed by #3772 or #3774
Closed

Kotlin Detekt cli_lint_mode= list_of_files support #3754

enciyo opened this issue Jul 9, 2024 · 2 comments · Fixed by #3772 or #3774

Comments

@enciyo
Copy link
Contributor

enciyo commented Jul 9, 2024 •
edited
Loading

Hi,
I want to run detekt for git diff. Is this possible with the latest changes?

For now I have overcome this by overriding the following value on the CI/CD side. But that doesn't seem like good behavior for us:

KOTLIN_DETEKT_ARGUMENTS: "--config config.yml --report sarif:megalinter-reports/detekt-result.sarif --report html:megalinter-reports/detekt-result.html --report md:megalinter-reports/detekt-result.md -i ${{ steps.diff.outputs.diff }}"

Originally posted by @enciyo in #3579 (comment)
@enciyo enciyo changed the title Hi, Kotlin Detekt cli_lint_mode= list_of_files support Jul 9, 2024
nvuillam added a commit that referenced this issue Jul 15, 2024
@nvuillam
Allow to override CLI_LINT_MODE when defined as project
f110400 
Fixes #3754
@nvuillam nvuillam mentioned this issue Jul 15, 2024
Merged
@nvuillam
Copy link
Member

@enciyo it was possible just before this PR ^^

#3590

I started a PR when we allow to override CLI_LINT_MODE if it is defined as project

nvuillam added a commit that referenced this issue Jul 15, 2024
@nvuillam
Allow to override CLI_LINT_MODE when defined as project (#3772)
2e5f5f5 
* Allow to override CLI_LINT_MODE when defined as project

Fixes #3754

* [MegaLinter] Apply linters fixes

---------

Co-authored-by: nvuillam <nvuillam@users.noreply.github.com>
@nvuillam
Copy link
Member

nvuillam commented Jul 15, 2024 •
edited
Loading

mmm I forgot the runtime part, i do another PR ^^

nvuillam added a commit that referenced this issue Jul 15, 2024
@nvuillam
Fix linter CLI_LINT_MODE override at runtime level
fbdaaa9 
Fixes #3754
@nvuillam nvuillam mentioned this issue Jul 15, 2024
Merged
nvuillam added a commit that referenced this issue Jul 15, 2024
@nvuillam
Fix linter CLI_LINT_MODE override at runtime level (#3774)
100d653 
Fixes #3754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nvuillam @enciyo