Allow removal of docker container when done

[dmitri-trofimov]

Fixes #1562

Proposed Changes

1. Add a command-line option --removecontainer to the megalinter runnner
2. The runner will pass the --rm option to docker run when the --removecontainer is specified
3. The --rm option ensures the removal of docker container (but not the image) when linting is done.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[codecov-commenter]

Codecov Report

Merging #1563 (11aa9d0) into main (7acb133) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1563      +/-   ##
==========================================
+ Coverage   84.50%   84.53%   +0.02%     
==========================================
  Files         145      145              
  Lines        3562     3562              
==========================================
+ Hits         3010     3011       +1     
+ Misses        552      551       -1     

Impacted Files	Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py	89.18% <0.00%> (+2.70%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7acb133...11aa9d0. Read the comment docs.

[Kurt-von-Laven]

I run docker system prune from time to time to deal with this, which works well for power users since it gives control over when the cleanup takes place, but forces additional maintenance onto the developer, and there is no guarantee that every MegaLinter user is familiar with Docker. I don’t have any particular comments on this PR besides the ones I already put on #1561, but my personal preference would be to ferry arguments through to Docker rather than mirror a subset of its API. Let us give @nvuillam a chance to weigh in before I send you off in a poor direction though.

[Kurt-von-Laven]

It looks good to me to merge once v6 is released!

[nvuillam]

@dmitri-trofimov now v6 is released, please can you upgrade your branche by merging main into it and solve conflicts ? :)

[nvuillam]

@dmitri-trofimov please could you upgrade your branch ? :)

[nvuillam]

Good, thanks for your contribution :)

[Kurt-von-Laven]

Apologies for making the same mistake twice. I just realized the argument name is likely going to trigger CSpell for our users and should be --remove-container. I can open a pull request to make the change before we release it if folks agree.

[nvuillam]

go @Kurt-von-Laven :)

[Kurt-von-Laven]

Went for it in #1693.