Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates related to JSON Schema #1625

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Updates related to JSON Schema #1625

merged 6 commits into from
Jul 19, 2022

Conversation

nvuillam
Copy link
Member

@nvuillam nvuillam commented Jul 19, 2022

Fixes #1621 and #1534

@nvuillam
Copy link
Member Author

nvuillam commented Jul 19, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.03s
✅ BASH shellcheck 7 0 0.25s
✅ BASH shfmt 7 0 0 0.28s
✅ COPYPASTE jscpd yes no 2.47s
✅ DOCKERFILE hadolint 102 0 18.8s
✅ JSON eslint-plugin-jsonc 20 0 0 2.06s
✅ JSON jsonlint 18 0 3.88s
✅ JSON v8r 20 0 11.18s
⚠️ MARKDOWN markdownlint 276 0 4 4.17s
✅ MARKDOWN markdown-link-check 276 0 4.64s
✅ MARKDOWN markdown-table-formatter 276 0 0 6.25s
✅ OPENAPI spectral 1 0 0.81s
⚠️ PYTHON bandit 161 50 2.01s
✅ PYTHON black 161 0 0 3.23s
✅ PYTHON flake8 161 0 2.34s
✅ PYTHON isort 161 0 0 0.59s
✅ PYTHON mypy 161 0 91.92s
✅ PYTHON pylint 161 0 14.52s
✅ REPOSITORY git_diff yes no 0.26s
✅ REPOSITORY secretlint yes no 10.96s
⚠️ REPOSITORY semgrep yes 244 44.52s
✅ REPOSITORY trivy yes no 23.19s
✅ SPELL cspell 862 0 21.5s
✅ SPELL misspell 697 0 0 0.7s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 78 0 0 2.18s
✅ YAML v8r 22 0 26.41s
✅ YAML yamllint 79 0 1.12s

See errors details in artifact MegaLinter reports on CI Job page

@nvuillam
Copy link
Member Author

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.07s
✅ BASH shellcheck 7 0 0.58s
✅ BASH shfmt 7 0 0 0.11s
✅ COPYPASTE jscpd yes no 5.01s
✅ DOCKERFILE hadolint 102 0 30.59s
✅ JSON eslint-plugin-jsonc 20 0 0 2.9s
✅ JSON jsonlint 18 0 6.97s
✅ JSON v8r 20 0 11.78s
⚠️ MARKDOWN markdownlint 276 2 4 5.53s
✅ MARKDOWN markdown-link-check 276 0 5.58s
✅ MARKDOWN markdown-table-formatter 276 2 0 6.21s
✅ OPENAPI spectral 1 0 1.17s
⚠️ PYTHON bandit 161 50 3.19s
✅ PYTHON black 161 0 0 4.29s
✅ PYTHON flake8 161 0 3.41s
✅ PYTHON isort 161 0 0 0.64s
✅ PYTHON mypy 161 0 125.54s
✅ PYTHON pylint 161 0 40.44s
⚠️ REPOSITORY devskim yes 100 1.44s
✅ REPOSITORY dustilock yes no 2.03s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 4.69s
⚠️ REPOSITORY semgrep yes 244 63.94s
✅ REPOSITORY syft yes no 2.48s
✅ REPOSITORY trivy yes no 15.42s
✅ SPELL cspell 862 0 28.87s
✅ SPELL misspell 697 2 0 0.66s
✅ XML xmllint 3 0 0.02s
✅ YAML prettier 78 0 0 3.26s
✅ YAML v8r 22 0 30.62s
✅ YAML yamllint 79 0 1.35s

See errors details in artifact MegaLinter reports on CI Job page

@nvuillam nvuillam merged commit d58f1ed into main Jul 19, 2022
@nvuillam nvuillam deleted the bugs/jsonschema branch July 19, 2022 22:04
@bdovaz
Copy link
Collaborator

bdovaz commented Jul 22, 2022

@nvuillam You have marked OUTPUT_FORMAT as deprecated but the OUTPUT_DETAIL parameter only works with tap reporter if the deprecated OUTPUT_FORMAT parameter is set:

if config.get("OUTPUT_DETAIL", "") == "detailed":

@nvuillam
Copy link
Member Author

@bdovaz I hesitated to remove TAP reporter in v6, as SARIF has become the new standard... :)

Do you use TAP reporter ? if yes, how ?

@bdovaz
Copy link
Collaborator

bdovaz commented Jul 22, 2022

@bdovaz I hesitated to remove TAP reporter in v6, as SARIF has become the new standard... :)

Do you use TAP reporter ? if yes, how ?

As an intermediate format to achieve something like this:

https://adinermie.com/publishing-github-super-linter-terraform-quality-checks-to-azure-devops-pipelines/

@bdovaz
Copy link
Collaborator

bdovaz commented Jul 26, 2022

Created a PR @nvuillam #1657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Megalinter Json Scheme Update
2 participants