Upgrade dotnet to v6

.automation/test/csharp/csharp_bad_02.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace HelloWorld
+{
+    class Program
+    {
+        static void Main (string[] args)
+        {
+            Console.WriteLine ("Hello World!");
+        }
+    }
+}

.automation/test/csharp/csharp_good_02.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace HelloWorld
+{
+    class Program
+    {
+        static void Main(string[] args)
+        {
+            Console.WriteLine("Hello World!");
+        }
+    }
+}

.automation/test/csharp/csharp_project.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net6.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+</Project>

.automation/test/sample_project_fixes/csharp_project/csharp_project.csproj

@@ -0,0 +1,10 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net6.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+</Project>

.automation/test/sample_project_fixes/dotnet_solution.sln

@@ -0,0 +1,31 @@
+
+Microsoft Visual Studio Solution File, Format Version 12.00
+# Visual Studio Version 17
+VisualStudioVersion = 17.2.32630.192
+MinimumVisualStudioVersion = 10.0.40219.1
+Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "csharp_project", "csharp_project\csharp_project.csproj", "{FF219771-9DBB-4FB0-8217-F77034831035}"
+EndProject
+Project("{778DAE3C-4631-46EA-AA77-85C1314464D9}") = "vbdotnet_project", "vbdotnet_project\vbdotnet_project.vbproj", "{AF06A915-8734-4B54-836D-A0E2BAE228EB}"
+EndProject
+Global
+	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		Debug|Any CPU = Debug|Any CPU
+		Release|Any CPU = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{FF219771-9DBB-4FB0-8217-F77034831035}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{FF219771-9DBB-4FB0-8217-F77034831035}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{FF219771-9DBB-4FB0-8217-F77034831035}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{FF219771-9DBB-4FB0-8217-F77034831035}.Release|Any CPU.Build.0 = Release|Any CPU
+		{AF06A915-8734-4B54-836D-A0E2BAE228EB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{AF06A915-8734-4B54-836D-A0E2BAE228EB}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{AF06A915-8734-4B54-836D-A0E2BAE228EB}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{AF06A915-8734-4B54-836D-A0E2BAE228EB}.Release|Any CPU.Build.0 = Release|Any CPU
+	EndGlobalSection
+	GlobalSection(SolutionProperties) = preSolution
+		HideSolutionNode = FALSE
+	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {4DFF31ED-FADA-4A6E-B9D4-51D89C3C1FFC}
+	EndGlobalSection
+EndGlobal

.automation/test/sample_project_fixes/vbdotnet_project/vbdotnet_project.vbproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <RootNamespace>vb_projecty</RootNamespace>
+    <TargetFramework>net6.0</TargetFramework>
+  </PropertyGroup>
+
+</Project>

.automation/test/vbdotnet/vb_projecty.vbproj

@@ -0,0 +1,9 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <RootNamespace>vb_projecty</RootNamespace>
+    <TargetFramework>net6.0</TargetFramework>
+  </PropertyGroup>
+
+</Project>

.automation/test/vbdotnet/vbdotnet_bad_2.vb

@@ -0,0 +1,7 @@
+Imports System
+
+Public Module Hello
+   Public Sub Main(  )
+      Console.WriteLine("hello, world"
+   End Sub
+End Module

.automation/test/vbdotnet/vbdotnet_good_2.vb

@@ -0,0 +1,7 @@
+Imports System
+
+Public Module Hello
+    Public Sub Main()
+        Console.WriteLine("hello, world")
+    End Sub
+End Module

CHANGELOG.md

@@ -8,6 +8,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 Note: Can be used with `oxsecurity/megalinter@beta` in your GitHub Action mega-linter.yml file, or with `oxsecurity/megalinter:beta` docker image
 
+- Upgrade to dotnet 6.0 + `list_of_files` for dotnet-format CLI lint mode to improve performances (requires `.csproj` or `.vbproj` in the repo)
+
 - Linter versions upgrades
   - [checkstyle](https://checkstyle.sourceforge.io) from 10.3.1 to **10.3.2** on 2022-08-01
   - [flake8](https://flake8.pycqa.org) from 5.0.0 to **5.0.1** on 2022-08-01

Dockerfile

@@ -265,7 +265,7 @@ RUN mkdir -p ${PWSH_DIRECTORY} \
 # CSHARP installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 
@@ -320,7 +320,7 @@ RUN curl -fLo coursier https://git.io/coursier-cli && \
 # Next line commented because already managed by another linter
 # RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
 #     && chmod +x dotnet-install.sh \
-#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 # Next line commented because already managed by another linter
 # ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 
@@ -497,7 +497,7 @@ ENV PATH="~/.raku/bin:/opt/rakudo-pkg/bin:/opt/rakudo-pkg/share/perl6/site/bin:$
 # Next line commented because already managed by another linter
 # RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
 #     && chmod +x dotnet-install.sh \
-#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 # Next line commented because already managed by another linter
 # ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 RUN dotnet tool install --global Microsoft.CST.DevSkim.CLI
@@ -555,7 +555,7 @@ RUN ML_THIRD_PARTY_DIR="/third-party/misspell" \
 # Next line commented because already managed by another linter
 # RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
 #     && chmod +x dotnet-install.sh \
-#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 # Next line commented because already managed by another linter
 # ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 RUN dotnet tool install --global TSQLLint

flavors/dotnet/Dockerfile

@@ -185,7 +185,7 @@ RUN mkdir -p ${PWSH_DIRECTORY} \
 # CSHARP installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 
@@ -204,7 +204,7 @@ ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 # Next line commented because already managed by another linter
 # RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
 #     && chmod +x dotnet-install.sh \
-#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 # Next line commented because already managed by another linter
 # ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 
@@ -309,7 +309,7 @@ RUN ML_THIRD_PARTY_DIR="/third-party/misspell" \
 # Next line commented because already managed by another linter
 # RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
 #     && chmod +x dotnet-install.sh \
-#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+#     && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 # Next line commented because already managed by another linter
 # ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 RUN dotnet tool install --global TSQLLint

flavors/security/Dockerfile

@@ -167,7 +167,7 @@ RUN ML_THIRD_PARTY_DIR="/third-party/kubeconform" \
 # devskim installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 RUN dotnet tool install --global Microsoft.CST.DevSkim.CLI

linters/csharp_dotnet_format/Dockerfile

@@ -107,7 +107,7 @@ ENV PATH="/node_modules/.bin:${PATH}"
 # CSHARP installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 

linters/sql_tsqllint/Dockerfile

@@ -107,7 +107,7 @@ ENV PATH="/node_modules/.bin:${PATH}"
 # tsqllint installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 RUN dotnet tool install --global TSQLLint

linters/vbdotnet_dotnet_format/Dockerfile

@@ -107,7 +107,7 @@ ENV PATH="/node_modules/.bin:${PATH}"
 # VBDOTNET installation
 RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
     && chmod +x dotnet-install.sh \
-    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+    && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
 
 ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 

megalinter/descriptors/csharp.megalinter-descriptor.yml

@@ -19,29 +19,33 @@ install:
     - |
       RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
           && chmod +x dotnet-install.sh \
-          && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+          && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
     - ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 linters:
   # DOTNET FORMAT
   - class: DotnetFormatLinter
     linter_name: dotnet-format
     is_formatter: true
-    linter_url: https://github.com/dotnet/format
+    linter_text: |
+      dotnet-format requires a `.sln` or `.csproj` file to run correctly.
+    linter_url: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-format
     linter_repo: https://github.com/dotnet/format
     linter_image_url: https://user-images.githubusercontent.com/9797472/61659851-6bbdc880-ac7d-11e9-95f7-d30c7de1a18a.png
+    pre_commands: dotnet --info
+    cli_lint_mode: list_of_files
     cli_lint_extra_args:
-      - "--folder"
-      - "--check"
+      - "{{WORKSPACE}}"
+      - "--verify-no-changes"
       - "--exclude"
       - "/"
       - "--include"
-    cli_lint_fix_arg_name: "--megalinter-fix-flag" # Workaround for PythonBlackOrIsortLinter class behavior
+    cli_lint_fix_arg_name: "--megalinter-fix-flag" # Workaround for DotnetFormatLinter class behavior
     cli_lint_fix_remove_args:
-      - "--check"
+      - "--verify-no-changes"
     linter_version_cache: "000"
     examples:
-      - "dotnet-format --folder --check --exclude / --include myfile.cs"
-      - "dotnet-format --folder --exclude / --include myfile.cs" # Fix
+      - "dotnet-format --verify-no-changes --exclude / --include myfile.cs myfile2.cs"
+      - "dotnet-format --exclude / --include myfile.cs myfile2.cs" # Fix
     install:
       dockerfile:
         - RUN /usr/share/dotnet/dotnet tool install -g dotnet-format

megalinter/descriptors/repository.megalinter-descriptor.yml

@@ -18,6 +18,7 @@ linters:
     linter_rules_configuration_url: https://github.com/microsoft/DevSkim/wiki/Analyze-Command
     linter_rules_ignore_config_url: https://github.com/microsoft/DevSkim/wiki/Analyze-Command
     linter_image_url: https://github.com/microsoft/DevSkim/raw/main/media/devskim_logo.svg
+    pre_commands: dotnet --info
     cli_lint_mode: project
     cli_lint_extra_args:
       - analyze
@@ -49,7 +50,7 @@ linters:
         - |
           RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
               && chmod +x dotnet-install.sh \
-              && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+              && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
         - ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
         - RUN dotnet tool install --global Microsoft.CST.DevSkim.CLI
     ide:

megalinter/descriptors/sql.megalinter-descriptor.yml

@@ -58,6 +58,7 @@ linters:
     linter_rules_url: https://github.com/tsqllint/tsqllint#rule-configuration
     linter_rules_configuration_url: https://github.com/tsqllint/tsqllint#rule-configuration
     linter_rules_inline_disable_url: https://github.com/tsqllint/tsqllint#disabling-rules-with-inline-comments
+    pre_commands: dotnet --info
     config_file_name: ".tsqllintrc"
     cli_lint_mode: list_of_files
     cli_config_arg_name: "--config"
@@ -81,7 +82,7 @@ linters:
         - |
           RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
               && chmod +x dotnet-install.sh \
-              && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+              && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
         - ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
         - RUN dotnet tool install --global TSQLLint
     ide:

megalinter/descriptors/vbdotnet.megalinter-descriptor.yml

@@ -19,28 +19,32 @@ install:
     - |
       RUN wget --tries=5 -q -O dotnet-install.sh https://dot.net/v1/dotnet-install.sh \
           && chmod +x dotnet-install.sh \
-          && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 5.0 -version latest
+          && ./dotnet-install.sh --install-dir /usr/share/dotnet -channel 6.0 -version latest
     - ENV PATH="${PATH}:/root/.dotnet/tools:/usr/share/dotnet"
 linters:
   # DOTNET FORMAT
   - class: DotnetFormatLinter
     linter_name: dotnet-format
     is_formatter: true
-    linter_url: https://github.com/dotnet/format
+    linter_text: |
+      dotnet-format requires a `.sln` or `.vbproj` file to run correctly.
+    linter_url: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-format
+    linter_repo: https://github.com/dotnet/format
     linter_image_url: https://user-images.githubusercontent.com/9797472/61659851-6bbdc880-ac7d-11e9-95f7-d30c7de1a18a.png
+    cli_lint_mode: list_of_files
     cli_lint_extra_args:
-      - "--folder"
-      - "--check"
+      - "{{WORKSPACE}}"
+      - "--verify-no-changes"
       - "--exclude"
       - "/"
       - "--include"
     cli_lint_fix_arg_name: "--megalinter-fix-flag" # Workaround to allow fix
     cli_lint_fix_remove_args:
-      - "--check"
+      - "--verify-no-changes"
     linter_version_cache: "000"
     examples:
-      - "dotnet-format --folder --check --exclude / --include myfile.vb"
-      - "dotnet-format --folder --exclude / --include myfile.vb"
+      - "dotnet-format --verify-no-changes --exclude / --include myfile.vb myfile2.vb"
+      - "dotnet-format --exclude / --include myfile.vb myfile2.vb"
     install:
       dockerfile:
         - RUN /usr/share/dotnet/dotnet tool install -g dotnet-format

megalinter/linters/DotnetFormatLinter.py

@@ -12,10 +12,21 @@ class DotnetFormatLinter(Linter):
 
     # Build the CLI command to call to lint a file
     def build_lint_command(self, file=None):
-        commands = [
-            f'cd "{os.path.realpath(os.path.dirname(file))}" || exit 1',
-            " ".join(super().build_lint_command(os.path.basename(file)))
-            + " | tee /dev/tty2 2>&1",
-            'exit "${PIPESTATUS[0]}"',
-        ]
+        if file is not None:
+            # cli_lint_mode = file
+            file = os.path.basename(file)
+            dotnet_format_command = " ".join(super().build_lint_command(file))
+            commands = [
+                f'cd "{os.path.realpath(os.path.dirname(file))}" || exit 1',
+                dotnet_format_command + " | tee /dev/tty2 2>&1",
+                'exit "${PIPESTATUS[0]}"',
+            ]
+
+        else:
+            # cli_lint_mode = list_of_files or project
+            dotnet_format_command = " ".join(super().build_lint_command(None))
+            commands = [
+                dotnet_format_command + " | tee /dev/tty2 2>&1",
+                'exit "${PIPESTATUS[0]}"',
+            ]
         return " && ".join(commands)