Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makefile linter within python flavor #1771

Merged
merged 3 commits into from
Aug 21, 2022

Conversation

nvuillam
Copy link
Member

Fixes #1760

@nvuillam
Copy link
Member Author

nvuillam commented Aug 21, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.02s
✅ BASH shellcheck 7 0 0.3s
✅ BASH shfmt 7 0 0 0.33s
✅ COPYPASTE jscpd yes no 2.15s
✅ DOCKERFILE hadolint 103 0 19.44s
✅ JSON eslint-plugin-jsonc 20 0 0 2.39s
✅ JSON jsonlint 18 0 0.25s
✅ JSON v8r 20 0 11.6s
⚠️ MARKDOWN markdownlint 281 0 5 4.31s
✅ MARKDOWN markdown-link-check 281 0 5.63s
✅ MARKDOWN markdown-table-formatter 281 0 0 7.61s
✅ OPENAPI spectral 1 0 0.9s
⚠️ PYTHON bandit 165 51 2.15s
✅ PYTHON black 165 0 0 3.5s
✅ PYTHON flake8 165 0 1.82s
✅ PYTHON isort 165 0 0 0.7s
✅ PYTHON mypy 165 0 100.93s
✅ PYTHON pylint 165 0 18.67s
✅ REPOSITORY checkov yes no 15.6s
✅ REPOSITORY git_diff yes no 0.28s
✅ REPOSITORY secretlint yes no 11.7s
✅ REPOSITORY trivy yes no 22.19s
✅ SPELL cspell 684 0 22.71s
✅ SPELL misspell 514 0 0 0.78s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 79 0 0 3.11s
✅ YAML v8r 22 0 26.13s
✅ YAML yamllint 80 0 1.35s

See errors details in artifact MegaLinter reports on CI Job page

@codecov-commenter
Copy link

Codecov Report

Merging #1771 (36bc4e8) into main (14a2e41) will increase coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1771      +/-   ##
==========================================
+ Coverage   83.51%   84.06%   +0.54%     
==========================================
  Files         160      160              
  Lines        4241     4241              
==========================================
+ Hits         3542     3565      +23     
+ Misses        699      676      -23     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 89.01% <0.00%> (+8.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvuillam
Copy link
Member Author

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.01s
✅ BASH shellcheck 7 0 0.27s
✅ BASH shfmt 7 0 0 0.04s
✅ COPYPASTE jscpd yes no 1.89s
✅ DOCKERFILE hadolint 103 0 15.55s
✅ JSON eslint-plugin-jsonc 20 0 0 2.56s
✅ JSON jsonlint 18 0 0.21s
✅ JSON v8r 20 0 11.23s
⚠️ MARKDOWN markdownlint 281 2 5 4.27s
✅ MARKDOWN markdown-link-check 281 0 4.94s
✅ MARKDOWN markdown-table-formatter 281 2 0 6.41s
✅ OPENAPI spectral 1 0 0.8s
⚠️ PYTHON bandit 165 51 2.19s
✅ PYTHON black 165 0 0 3.18s
✅ PYTHON flake8 165 0 2.04s
✅ PYTHON isort 165 0 0 0.35s
✅ PYTHON mypy 165 0 97.38s
✅ PYTHON pylint 165 0 17.95s
✅ REPOSITORY checkov yes no 13.63s
⚠️ REPOSITORY devskim yes 59 1.11s
✅ REPOSITORY dustilock yes no 2.99s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY secretlint yes no 3.79s
✅ REPOSITORY syft yes no 1.87s
✅ REPOSITORY trivy yes no 13.78s
✅ SPELL cspell 684 0 20.49s
✅ SPELL misspell 514 2 0 0.45s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 79 0 0 2.43s
✅ YAML v8r 22 0 25.77s
✅ YAML yamllint 80 0 1.1s

See errors details in artifact MegaLinter reports on CI Job page

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

@nvuillam nvuillam merged commit 34a274b into main Aug 21, 2022
@nvuillam nvuillam deleted the features/makefile-python-flavor branch August 21, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request new MegaLinter flavor
2 participants