Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default npm-groovy-lint extra arguments #1973

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

nvuillam
Copy link
Member

Fixes #1872

@nvuillam
Copy link
Member Author

nvuillam commented Oct 17, 2022

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.02s
✅ BASH shellcheck 7 0 0.26s
✅ BASH shfmt 7 0 0 0.3s
✅ COPYPASTE jscpd yes no 2.11s
✅ DOCKERFILE hadolint 105 0 8.79s
✅ JSON eslint-plugin-jsonc 21 0 0 2.13s
✅ JSON jsonlint 19 0 0.27s
✅ JSON v8r 21 0 16.1s
⚠️ MARKDOWN markdownlint 294 0 5 5.23s
✅ MARKDOWN markdown-link-check 294 0 5.12s
✅ MARKDOWN markdown-table-formatter 294 0 0 7.09s
✅ OPENAPI spectral 1 0 0.81s
⚠️ PYTHON bandit 170 55 2.51s
✅ PYTHON black 170 0 0 4.14s
✅ PYTHON flake8 170 0 2.06s
✅ PYTHON isort 170 0 0 0.7s
✅ PYTHON mypy 170 0 7.34s
✅ PYTHON pylint 170 0 12.46s
⚠️ PYTHON pyright 170 273 18.2s
✅ REPOSITORY checkov yes no 27.71s
✅ REPOSITORY git_diff yes no 0.29s
✅ REPOSITORY secretlint yes no 8.79s
✅ REPOSITORY trivy yes no 21.67s
✅ SPELL cspell 706 0 18.35s
✅ SPELL misspell 533 0 0 0.74s
✅ XML xmllint 3 0 0.01s
✅ YAML prettier 80 0 0 3.31s
✅ YAML v8r 22 0 46.14s
✅ YAML yamllint 81 0 1.36s

See errors details in artifact MegaLinter reports on CI Job page

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

Merging #1973 (a6ffa1f) into main (f14608f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
+ Coverage   82.03%   82.06%   +0.02%     
==========================================
  Files         157      157              
  Lines        3384     3384              
==========================================
+ Hits         2776     2777       +1     
+ Misses        608      607       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvuillam
Copy link
Member Author

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 7 0 0.04s
✅ BASH shellcheck 7 0 0.4s
✅ BASH shfmt 7 0 0 0.07s
✅ COPYPASTE jscpd yes no 4.12s
✅ DOCKERFILE hadolint 105 0 11.65s
✅ JSON eslint-plugin-jsonc 21 0 0 3.38s
✅ JSON jsonlint 19 0 0.32s
✅ JSON v8r 21 0 23.37s
⚠️ MARKDOWN markdownlint 294 0 5 7.7s
✅ MARKDOWN markdown-link-check 294 0 7.56s
✅ MARKDOWN markdown-table-formatter 294 0 0 8.94s
✅ OPENAPI spectral 1 0 1.48s
⚠️ PYTHON bandit 170 55 4.05s
✅ PYTHON black 170 0 0 5.87s
✅ PYTHON flake8 170 0 3.15s
✅ PYTHON isort 170 0 0 0.73s
✅ PYTHON mypy 170 0 12.71s
✅ PYTHON pylint 170 0 18.65s
⚠️ PYTHON pyright 170 271 27.35s
✅ REPOSITORY checkov yes no 41.76s
⚠️ REPOSITORY devskim yes 59 1.64s
✅ REPOSITORY dustilock yes no 1.51s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 5.91s
✅ REPOSITORY syft yes no 2.98s
✅ REPOSITORY trivy yes no 24.94s
✅ SPELL cspell 706 0 30.68s
✅ SPELL misspell 533 0 0 0.66s
✅ XML xmllint 3 0 0.0s
✅ YAML prettier 80 0 0 4.52s
✅ YAML v8r 22 0 63.96s
✅ YAML yamllint 81 0 1.98s

See errors details in artifact MegaLinter reports on CI Job page

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@nvuillam nvuillam merged commit 3d6bd48 into main Oct 17, 2022
@nvuillam nvuillam deleted the fixes/npm-groovy-lint branch October 17, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm-groovy-lint is raising a false positive error on GitHub Actions
2 participants