-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy additional Docker images to GitHub Container Registry #2117
Conversation
Some questions about this:
Once these questions are answered, I'll update the |
This pull request has been automatically marked as stale because it has not had recent activity. If you think this pull request should stay open, please remove the |
Ping @nvuillam, can you answer this questions? |
@bdovaz beta, beta-flavors and beta-linters will validate that it work, so the release jobs have more chances to work too :) |
I recently found this discussion claiming that GHCR is no faster than Docker Hub for GitHub Actions. So, I wonder whether it makes sense to further pursue this PR. |
docker pulls on docker hub has download limitations (not applied on github actions), so it still can be iteresting to use ghcr image, especially for self hossted runners :) |
Thai Pangsakulyanont reported improved performance building and pushing to GHCR, which makes me skeptical that pulling is somehow slower. We wrote ScribeMD/docker-cache, automating approach 📦 in the blog post, and it outperforms pulling directly from Docker Hub. In any case, we should measure the performance ourselves since it may have changed over time. |
And what about simply when there are some outages? It is native to GitHub, and the whole build doesn't need to be done twice anyway, only two pushes instead of one. |
I can continue with this next week. If someone else wants to work on it in the meantime, feel free to do so. |
Codecov Report
@@ Coverage Diff @@
## main #2117 +/- ##
==========================================
+ Coverage 82.60% 83.11% +0.51%
==========================================
Files 170 170
Lines 4484 4484
==========================================
+ Hits 3704 3727 +23
+ Misses 780 757 -23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@lars-reimann you need to add this word to .cspell.json file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR, nice job, thanks a lot for your contribution :)
By default, bots can't edit |
@Kurt-von-Laven @echoix it worked thru web UI :) |
thanks again @lars-reimann :) |
Fixes partially #1472
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance