Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trivy config file parameters #2154

Merged
merged 3 commits into from
Dec 21, 2022
Merged

Conversation

bdovaz
Copy link
Collaborator

@bdovaz bdovaz commented Dec 20, 2022

  • Add config_file_name and cli_config_arg_name
  • Change configuration url to a more suitable one
  • Change old urls to the current version
  • Fix broken banner image url

- Change old urls to the current version
- Fix broken banner image url
@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 20, 2022

I have doubts whether to put /v0.35/ or /latest/.

v0.35:

  • Difficult to maintain, it is easy to forget to update the version....
  • Aim for the version that corresponds to the one in the image.

latest:

  • Not to be maintained.
  • It always points to the latest version and it doesn't have to be the one in the image.

@nvuillam
Copy link
Member

@bdovaz I don't remember why we did not use latest
If it works with latest (and returns correctly the version number), go with latest , that's the default way for other linters

@bdovaz
Copy link
Collaborator Author

bdovaz commented Dec 20, 2022

@nvuillam changed!

@codecov-commenter
Copy link

Codecov Report

Merging #2154 (5ed5d80) into main (0af38af) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2154      +/-   ##
==========================================
+ Coverage   82.36%   82.41%   +0.04%     
==========================================
  Files         158      166       +8     
  Lines        3413     4429    +1016     
==========================================
+ Hits         2811     3650     +839     
- Misses        602      779     +177     
Impacted Files Coverage Δ
...alinter/tests/test_megalinter/helpers/utilstest.py 80.95% <0.00%> (-8.06%) ⬇️
megalinter/utils.py 82.96% <0.00%> (ø)
megalinter/__init__.py 100.00% <0.00%> (ø)
megalinter/Linter.py 84.67% <0.00%> (ø)
megalinter/Reporter.py 86.36% <0.00%> (ø)
megalinter/config.py 89.74% <0.00%> (ø)
megalinter/constants.py 100.00% <0.00%> (ø)
megalinter/setup.py 0.00% <0.00%> (ø)
megalinter/run.py 0.00% <0.00%> (ø)
megalinter/reporters/SarifReporter.py 79.13% <0.00%> (+1.56%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, many thanks for your contribution :)

@nvuillam nvuillam merged commit 4e80444 into oxsecurity:main Dec 21, 2022
@bdovaz bdovaz deleted the feature/trivy-config branch December 21, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants