Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix syft logo #2282

Merged
merged 1 commit into from
Jan 21, 2023
Merged

docs: fix syft logo #2282

merged 1 commit into from
Jan 21, 2023

Conversation

pjungermann
Copy link
Contributor

Instead of the syft logo, the Semgrep logo was displayed.

Logo reference taken from https://github.com/anchore/syft/blob/641bccc79bd98af48dcb450af9b217d68b1d5662/README.md

Fixes #

Proposed Changes

  1. ...
  2. ...
  3. ...

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Instead of the syft logo, the Semgrep logo was displayed.

Logo reference taken from https://github.com/anchore/syft/blob/641bccc79bd98af48dcb450af9b217d68b1d5662/README.md
@pjungermann pjungermann requested a review from nvuillam as a code owner January 21, 2023 00:15
@codecov-commenter
Copy link

Codecov Report

Merging #2282 (8dd9a7f) into main (653c086) will increase coverage by 0.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
+ Coverage   82.39%   82.90%   +0.50%     
==========================================
  Files         171      171              
  Lines        4521     4521              
==========================================
+ Hits         3725     3748      +23     
+ Misses        796      773      -23     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.74% <0.00%> (+2.56%) ⬆️
...alinter/tests/test_megalinter/helpers/utilstest.py 89.01% <0.00%> (+8.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Kurt-von-Laven Kurt-von-Laven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you for the contribution. Would you mind adding a bullet to the CHANGELOG and running build.sh?

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for the PR :)

@nvuillam
Copy link
Member

@Kurt-von-Laven auto-update linters job will do it, you can merge :)

@Kurt-von-Laven Kurt-von-Laven merged commit 23ced5e into oxsecurity:main Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants