Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max-parallel to matrix in jobs #2397

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Feb 27, 2023

Should help when we are running out of runners. These are just a naive estimation of what could be useful. We could probably better tune these later easily, if we feel that a certain matrix is too long because of these limits, and that it doesn't end up having too long of a queue in busy (contribution-wise) times.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategymax-parallel

The branch on my fork was failing for some tests of sfdx

Proposed Changes

  1. Set strategy: max-parallel: to workflows with a job matrix

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix added enhancement New feature or request automation labels Feb 27, 2023
@echoix echoix requested a review from nvuillam as a code owner February 27, 2023 02:22
@echoix
Copy link
Collaborator Author

echoix commented Feb 27, 2023

The branch on my fork was failing for some tests of sfdx
image

@echoix
Copy link
Collaborator Author

echoix commented Feb 27, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.02s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.29s
✅ COPYPASTE jscpd yes no 2.73s
✅ DOCKERFILE hadolint 114 0 15.83s
✅ JSON eslint-plugin-jsonc 21 0 0 2.06s
✅ JSON jsonlint 19 0 0.24s
✅ JSON v8r 21 0 11.99s
⚠️ MARKDOWN markdownlint 309 0 230 5.91s
✅ MARKDOWN markdown-link-check 309 0 5.48s
✅ MARKDOWN markdown-table-formatter 309 0 0 19.12s
✅ OPENAPI spectral 1 0 1.74s
⚠️ PYTHON bandit 183 47 1.95s
✅ PYTHON black 183 0 0 3.71s
✅ PYTHON flake8 183 0 1.71s
✅ PYTHON isort 183 0 0 0.67s
✅ PYTHON mypy 183 0 6.94s
✅ PYTHON pylint 183 0 11.52s
⚠️ PYTHON pyright 183 254 17.52s
✅ REPOSITORY checkov yes no 28.97s
✅ REPOSITORY git_diff yes no 0.31s
✅ REPOSITORY secretlint yes no 13.85s
✅ REPOSITORY trivy yes no 26.62s
✅ SPELL cspell 745 0 19.55s
✅ SPELL misspell 566 0 0 0.78s
✅ XML xmllint 3 0 0 0.29s
✅ YAML prettier 81 0 0 2.81s
✅ YAML v8r 23 0 58.92s
✅ YAML yamllint 82 0 1.13s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz check comments :)

.github/workflows/deploy-RELEASE-linters.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-RELEASE-flavors.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants