-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MegaLinter version displayed in logs #2485
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
✅ BASH | bash-exec | 6 | 0 | 0.02s | |
✅ BASH | shellcheck | 6 | 0 | 0.13s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0.37s |
✅ COPYPASTE | jscpd | yes | no | 2.47s | |
✅ DOCKERFILE | hadolint | 115 | 0 | 11.27s | |
✅ JSON | eslint-plugin-jsonc | 21 | 0 | 0 | 2.16s |
✅ JSON | jsonlint | 19 | 0 | 0.18s | |
✅ JSON | v8r | 21 | 0 | 11.47s | |
markdownlint | 311 | 0 | 230 | 6.68s | |
markdown-link-check | 311 | 102 | 315.58s | ||
✅ MARKDOWN | markdown-table-formatter | 311 | 0 | 0 | 19.7s |
✅ OPENAPI | spectral | 1 | 0 | 1.11s | |
bandit | 184 | 55 | 1.96s | ||
✅ PYTHON | black | 184 | 0 | 0 | 4.55s |
✅ PYTHON | flake8 | 184 | 0 | 1.35s | |
✅ PYTHON | isort | 184 | 0 | 0 | 0.72s |
✅ PYTHON | mypy | 184 | 0 | 6.7s | |
✅ PYTHON | pylint | 184 | 0 | 10.94s | |
pyright | 184 | 250 | 15.4s | ||
✅ REPOSITORY | checkov | yes | no | 28.51s | |
✅ REPOSITORY | git_diff | yes | no | 0.34s | |
✅ REPOSITORY | secretlint | yes | no | 12.26s | |
✅ REPOSITORY | trivy | yes | no | 20.95s | |
✅ SPELL | cspell | 750 | 0 | 19.45s | |
✅ SPELL | misspell | 570 | 0 | 0 | 0.89s |
✅ XML | xmllint | 3 | 0 | 0 | 0.4s |
✅ YAML | prettier | 81 | 0 | 0 | 2.86s |
✅ YAML | v8r | 23 | 0 | 44.44s | |
✅ YAML | yamllint | 82 | 0 | 1.0s |
See detailed report in MegaLinter reports
8097dfc
to
eca961e
Compare
@nvuillam Like it !
And also in descriptors links, like this one
|
@llaville the retag-push was not enough... I had to update the release workflows to build again FROM newest beta version and add appropriate ENV vars & LABEL :) |
Did you try pulling the image before, to populate the cache with what already exists? This way, maybe only the last layers would need to be "built" |
https://github.com/oxsecurity/megalinter/blob/main/Dockerfile-release Nope, but the performances are acceptable :) |
I'm not even sure that those lines are necessary, as they are already in the base image... but as i have doubts I put them anyway ^^ Do you think they should be removed ?
|
I don't have a clue indeed, I haven't played with a similar case yet to know the behaviour. But what I can imagine that could be an improvement over the Dockerfile-release, is to add a default value to the argument, for the base image at least, so it could be already there if we want to manually run the build, without entering every single argument at the command line. But I'm wondering if it doesn't add extra useless layers (the env ones) when doing this. And what about basing a release on an already released base, does it still work (imagine without any commits in between) |
We will never manually build a release version :p Indeed I also think about useless layers :p |
Related to #2425