Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed incorrect link. #2613

Merged
merged 4 commits into from
May 13, 2023
Merged

Fixed incorrect link. #2613

merged 4 commits into from
May 13, 2023

Conversation

Doommius
Copy link
Contributor

@Doommius Doommius commented May 3, 2023 •
edited
Loading

Fixed lint that points to GitLab instead of Azure pipelines.

Fixes #

Proposed Changes

  1. …
  2. …
  3. …

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@Doommius
Fixed incorrect link.
7a21ab4 
Fixed lint that points to GitLab instead of Azure pipelines.
@Doommius Doommius requested a review from nvuillam as a code owner May 3, 2023 11:22
@echoix
Copy link
Collaborator

echoix commented May 3, 2023 •
edited by github-actions bot
Loading

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed updating files.

@echoix
Copy link
Collaborator

echoix commented May 3, 2023

@nvuillam I'm not sure why the jsonschema needed to change. I thought that there might have been a documentation change with this PR, but not sure why the whole file was changed. Maybe remove the last commit?

@nvuillam
Copy link
Member

nvuillam commented May 3, 2023

Probably just formatting:)

@nvuillam
Copy link
Member

nvuillam commented May 3, 2023

CI is temporary broken, I don't know if it's because of my updates or because an upgraded linter that makes a mess ^^
Once solved we'll be able to merge this PR :)

nvuillam
nvuillam approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fo the catch and for the PR :)

nvuillam
nvuillam approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fo the catch and for the PR :)

nvuillam
nvuillam approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fo the catch and for the PR :)

nvuillam
nvuillam approved these changes May 13, 2023
View reviewed changes
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks fo the catch and for the PR :)

@nvuillam nvuillam merged commit 1d9f4dd into oxsecurity:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvuillam nvuillam nvuillam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doommius @echoix @nvuillam