Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stale workflow: remove trigger on comments and explicit permissions #2641

Merged
merged 5 commits into from
May 14, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented May 14, 2023

Proposed Changes

  1. Triggering on each issue/pr comment isn’t used anymore, dates back to 2021.
  2. Add explicit permissions, as recommended in https://github.com/actions/stale/tree/03af7c36d33f4905e618fac0a1bb7e6d05f0d41b#recommended-permissions

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix added the github_actions Pull requests that update Github_actions code label May 14, 2023
@echoix echoix self-assigned this May 14, 2023
@echoix echoix requested a review from nvuillam as a code owner May 14, 2023 18:30
@echoix
Copy link
Collaborator Author

echoix commented May 14, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ BASH bash-exec 6 0 0.01s
✅ BASH shellcheck 6 0 0.13s
✅ BASH shfmt 6 0 0 0.36s
✅ COPYPASTE jscpd yes no 3.71s
✅ DOCKERFILE hadolint 116 0 17.89s
✅ JSON eslint-plugin-jsonc 23 0 0 2.78s
✅ JSON jsonlint 21 0 0.2s
✅ JSON v8r 23 0 16.48s
⚠️ MARKDOWN markdownlint 308 0 229 156.35s
✅ MARKDOWN markdown-link-check 308 0 6.79s
✅ MARKDOWN markdown-table-formatter 308 0 0 20.91s
✅ OPENAPI spectral 1 0 1.41s
⚠️ PYTHON bandit 188 58 2.28s
✅ PYTHON black 188 0 0 4.88s
✅ PYTHON flake8 188 0 2.19s
✅ PYTHON isort 188 0 0 0.81s
✅ PYTHON mypy 188 0 8.26s
✅ PYTHON pylint 188 0 14.05s
⚠️ PYTHON pyright 188 301 23.22s
✅ PYTHON ruff 188 0 0 0.45s
✅ REPOSITORY checkov yes no 35.16s
✅ REPOSITORY git_diff yes no 0.35s
✅ REPOSITORY secretlint yes no 18.65s
✅ REPOSITORY trivy yes no 26.54s
✅ SPELL cspell 613 0 25.72s
⚠️ SPELL vale 220 62 29.73s
✅ XML xmllint 3 0 0 0.37s
✅ YAML prettier 156 0 0 5.37s
✅ YAML v8r 98 0 136.74s
✅ YAML yamllint 157 0 1.45s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator Author

echoix commented May 14, 2023

I wanted to report this last Easter, but didn't get to it yet. It's in the same idea of #2614, reducing unneeded workflow runs when nothing is done.

@nvuillam nvuillam merged commit 0cbe0d6 into oxsecurity:main May 14, 2023
@nvuillam
Copy link
Member

thanks for the PR @echoix :)

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great !

@echoix echoix deleted the dev/update-stale-workflow branch May 14, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants