Only check for @generated-like markers in file header

[sanmai-NL]

Check a large but limited buffer from the start of the file. Do not assume UTF-8 encoding and text decode at all, but search for byte string. First check for the marker with the highest priority, to short-circuit return when it is found.

This prevents performance problems with large files.

Proposed Changes

1. Small, adequately described in first commit message.

Readiness Checklist

Author/Contributor

• Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[nvuillam]

@sanmai-NL that's a brilliant idea for perfs :)

Please can you also update the CHANGELOG.md ?

[sanmai-NL]

@nvuillam How to add labels?

[nvuillam]

done ^^

[sanmai-NL]

I examined the docs, and I think they needn't be changed, likewise, I don't consider this change breaking for spec-compliant data. Before the marker was sought anywhere in the source file, now it is only in the beginning. The latter is specified by the spec. ‘The beginning’ is not an objective criterion. Hopefully the original spec can be updated to define a limit.

[nvuillam]

@sanmai-NL works for me :)

[sanmai-NL]

@nvuillam Do you have chance to review this small but impactful change soon? Can it be included in v7?

[nvuillam]

@sanmai-NL it will be in 7.1.0 , sorry v7 has just been released :)

Please can you check our comments with @Kurt-von-Laven about readability of the condition ?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

[nvuillam]

@sanmai-NL friendly ping ? :)

[sanmai-NL]

I don't see unaddressed comments.

[nvuillam]

@sanmai-NL please can you add SOURCEFILEHEADER in cspell.json so the CI pass ?

I also think that there is some issue with the git delta in CHANGELOG.md

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

[sanmai-NL]

@nvuillam I don't know exactly the what and why of your instructions. Can you make the required tweaks to this branch?

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

[sanmai-NL]

/remove stale

[sanmai-NL]

@nvuillam

[nvuillam]

@sanmai-NL you need to merge conflicts to make your branch up to date :)

[sanmai-NL]

@sanmai-NL you need to merge conflicts to make your branch up to date :)

@nvuillam Ready to merge.

[nvuillam]

Thanks for your contribution that should improve performances :)
Once CI is ok i'll merge :)