Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failure message in ChatOps build-command and Slash dispatcher #3037

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Oct 23, 2023

I found a flaw that if a commit was made before the build-command made its commit, the action would obviously fail, but wouldn't show up in the edited comment. So I added to try to git pull before the git commit action, if it could help, and update the comment if it fails

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix added github_actions Pull requests that update Github_actions code automation labels Oct 23, 2023
@echoix echoix requested a review from nvuillam as a code owner October 23, 2023 04:54
@echoix echoix changed the title Fix/build command failure message Add failure message in ChatOps build-command and Slash dispatcher Oct 23, 2023
@echoix echoix temporarily deployed to dev October 23, 2023 04:57 — with GitHub Actions Inactive
@echoix echoix temporarily deployed to dev October 23, 2023 04:57 — with GitHub Actions Inactive
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good :)

@nvuillam nvuillam merged commit 8fa7597 into oxsecurity:main Oct 23, 2023
3 checks passed
@echoix echoix deleted the fix/build-command-failure-message branch October 23, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants