-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C flavor #3067
C flavor #3067
Conversation
Next commit will build the descriptive items for this flavor.
Adds a new flavor for pure c_cpp developement. This flavor can later add the clang-format and other linters suggested in oxsecurity#763
I will still add clang-format. I just wanted to keep my first PR simple as this is my first contribution. |
@@ -2,6 +2,7 @@ descriptor_id: C | |||
descriptor_type: language | |||
descriptor_flavors: | |||
- cupcake | |||
- c_cpp | |||
- dotnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see a problem here when it comes to clang-format
being added. I would naturally put that linter in here and the cpp descriptor file.
However, if I understand it right, that would mean clang-format
is also added to the cupcake
, dotnet
, and dotnetweb
linters. I think we only want it in this new c_cpp
linter. Right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daltonv you can override descriptor_flavors at linter level, so you could add the following property on clang-format linter definition :)
descriptor_flavors:
- c_cpp
/build
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice to me, many thanks for your contribution :)
Proposed Changes
Adds a new c_cpp flavor that can later be used by clang-format (see #763)
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance