Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C flavor #3067

Merged
merged 3 commits into from
Nov 4, 2023
Merged

C flavor #3067

merged 3 commits into from
Nov 4, 2023

Conversation

daltonv
Copy link
Contributor

@daltonv daltonv commented Nov 3, 2023

Proposed Changes

Adds a new c_cpp flavor that can later be used by clang-format (see #763)

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Next commit will build the descriptive items for this flavor.
Adds a new flavor for pure c_cpp developement. This flavor can later
add the clang-format and other linters suggested in
oxsecurity#763
@daltonv
Copy link
Contributor Author

daltonv commented Nov 3, 2023

I will still add clang-format. I just wanted to keep my first PR simple as this is my first contribution.

@daltonv daltonv marked this pull request as ready for review November 3, 2023 08:11
@@ -2,6 +2,7 @@ descriptor_id: C
descriptor_type: language
descriptor_flavors:
- cupcake
- c_cpp
- dotnet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see a problem here when it comes to clang-format being added. I would naturally put that linter in here and the cpp descriptor file.

However, if I understand it right, that would mean clang-format is also added to the cupcake, dotnet, and dotnetweb linters. I think we only want it in this new c_cpp linter. Right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daltonv you can override descriptor_flavors at linter level, so you could add the following property on clang-format linter definition :)

     descriptor_flavors: 
        - c_cpp

@echoix
Copy link
Collaborator

echoix commented Nov 3, 2023

/build

Command run output
Build command workflow started.
Installing dependencies
Running script ./build.sh
Build command workflow completed without updating files.

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice to me, many thanks for your contribution :)

@nvuillam nvuillam merged commit 608189f into oxsecurity:main Nov 4, 2023
6 checks passed
@daltonv daltonv deleted the c_flavor branch March 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants