Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Gitleaks --no-git doesn't work anymore #3112

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fixed Gitleaks --no-git doesn't work anymore #3112

merged 2 commits into from
Nov 14, 2023

Conversation

VictorRos
Copy link
Contributor

@VictorRos VictorRos commented Nov 14, 2023

Contributes to #2945

  • Regression on the --no-git option which was systematically deleted.

    This prevents Gitleaks from treating git repository as a regular directory and scan those files.

Proposed Changes

  1. Split condition --redact or --no-git
  2. Get back to previous --no-git condition

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

* Regression on the `--no-git` option which was systematically deleted.

  This prevents Gitleaks from treating git repository as a regular directory and scan those files.
@VictorRos
Copy link
Contributor Author

VictorRos commented Nov 14, 2023

Notes:

  1. Locally I couldn't run make commands on my Mac

    Following documentation, I got stuck when running make reinitialization

    /bin/bash: -c: line 1: syntax error: unexpected end of file
    make[3]: *** [python-venv-init] Error 2
    make[2]: *** [python-bootstrap] Error 2
    make[1]: *** [bootstrap] Error 2
    make: *** [reinitialization] Error 2
  2. I tried Gitpod

    I tried running make tests, make tests-fast or make megalinter-tests.

    But MegaLinter is stuck so I have to kill process : /

    In final, currently I don't know if tests are OK or not.

    I try to rerun them an wait for one hour, then I will update current status.

    MegaLinter is stuck even after waiting 1 hour 😢

    MegaLinter stuck

  3. Linter Lychee failed even on main branch without my changes

    MegaLinter Lychee error

    https://www.pylint.org/pylint.svg returns 403 in japanese

    Pylint 403

    I have created an issue to track it Pylint logo returns a 403 #3113

Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not let this great PR be stuck because of pylint.org is down ;)
Many thanks for the fix :)

@nvuillam nvuillam merged commit 57095f0 into oxsecurity:main Nov 14, 2023
5 of 7 checks passed
@VictorRos VictorRos deleted the features/2945-gitleaks-no-git branch November 14, 2023 18:24
@echoix
Copy link
Collaborator

echoix commented Nov 14, 2023

Let's not let this great PR be stuck because of pylint.org is down ;)

Many thanks for the fix :)

pylint-dev/pylint#8934

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants