Update ktlint
descriptor to support list_of_files
and better error counting
#3575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
Proposed Changes
list_of_files
mode inKOTLIN_KTLINT
(which it supports OOB)Readiness Checklist
Author/Contributor
Unfortunately, I haven't been able for the life of me to run a proper build and test, as
make
is causing all sorts of headaches that I couldn't figure out... Themake
version in MacOS is very old (3.81 from 2006) and the newer version I installed (4.4.1, calledgmake
) somehow hangs even on trivial tasks likegmake help
.So I've only been able to test by compiling a local image, since the dockerfile appears unchanged (
docker buildx build -f linters/kotlin_ktlint/Dockerfile .
) and run it, but I couldn't rebuild everything and run tests...Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance