Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Powershell Error Table Format Improvements #3620

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

TommyE123
Copy link
Contributor

@TommyE123 TommyE123 commented Jun 7, 2024

Fixes #3603

Proposed Changes

  1. Check if we are running in a CI environment (github_actions, gitlab_ci, azure_pipelines) and if so use a default table width of 150.
  2. Default back to getting the terminal size if we are not in a CI environment. (Existing functionality)
  3. Cleaned up alignment of columns.

Test Results

AZURE DEVOPS
image

GITLAB
image

GITHUB
image

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)

Reviewing Maintainer

  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix echoix added enhancement New feature or request python Pull requests that update Python code labels Jun 7, 2024
@echoix
Copy link
Collaborator

echoix commented Jun 7, 2024

Just to make sure, the three CI in is_ci() supports widths of 150 columns?

Otherwise, it's great and ready to go!

@TommyE123
Copy link
Contributor Author

Test evidence updated to show all 3 CI outputs 😉

Just to make sure, the three CI in is_ci() supports widths of 150 columns?

Otherwise, it's great and ready to go!

@TommyE123 TommyE123 changed the title bug: Powershell Error Table Format Improvements enhancement: Powershell Error Table Format Improvements Jun 7, 2024
@echoix echoix merged commit 0687db9 into oxsecurity:main Jun 7, 2024
6 checks passed
@echoix
Copy link
Collaborator

echoix commented Jun 7, 2024

Thanks again!

@TommyE123 TommyE123 deleted the PS_Table_Improvements branch June 8, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powershell error table formatting issue
2 participants