Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to renovate PRs #3643

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add label to renovate PRs #3643

merged 1 commit into from
Jun 10, 2024

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Jun 9, 2024

I observed that dependabot PRs had labels while renovate didn't have some assigned.

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Copy link
Contributor

github-actions bot commented Jun 9, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ API spectral 2 0 3.19s
✅ BASH bash-exec 5 0 0.02s
✅ BASH shellcheck 5 0 0.12s
✅ BASH shfmt 5 0 0 0.75s
✅ COPYPASTE jscpd yes no 3.91s
✅ DOCKERFILE hadolint 130 0 18.02s
✅ JSON jsonlint 18 0 0.23s
✅ JSON v8r 20 0 30.57s
⚠️ MARKDOWN markdownlint 265 0 272 33.05s
✅ MARKDOWN markdown-table-formatter 265 0 0 142.05s
✅ OPENAPI spectral 2 0 3.04s
⚠️ PYTHON bandit 211 64 6.17s
✅ PYTHON black 211 0 0 6.08s
✅ PYTHON flake8 211 0 2.46s
✅ PYTHON isort 211 0 0 1.39s
✅ PYTHON mypy 211 0 19.56s
✅ PYTHON pylint 211 0 16.81s
✅ PYTHON ruff 211 0 0 0.72s
✅ REPOSITORY checkov yes no 39.06s
✅ REPOSITORY git_diff yes no 0.6s
⚠️ REPOSITORY grype yes 1 25.88s
✅ REPOSITORY secretlint yes no 19.22s
✅ REPOSITORY trivy yes no 19.29s
✅ REPOSITORY trivy-sbom yes no 10.25s
⚠️ REPOSITORY trufflehog yes 1 13.99s
✅ SPELL cspell 693 0 28.68s
⚠️ SPELL lychee 346 5 5.19s
✅ XML xmllint 3 0 0 0.71s
✅ YAML prettier 161 0 0 6.1s
✅ YAML v8r 102 0 195.18s
✅ YAML yamllint 162 0 2.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@echoix
Copy link
Collaborator Author

echoix commented Jun 10, 2024

Dependabot also applied other labels sometimes, like "docker" and the "dependencies" label to PRs. To get the same here, it's possible to configure renovate with package rules that apply to multiple packages selected by a criteria, group, or name, and apply additional specific labels, but it seems like a pain.

We could also use the actions/labeler action for all of our PRs, but the exactitude of the categories (like Python for pip dependencies) might just be impossible without using renovate for that. But is there really a value for that?

@nvuillam nvuillam merged commit 2819e3a into main Jun 10, 2024
127 checks passed
@nvuillam nvuillam deleted the echoix-patch-3 branch June 10, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants