-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: ansible-lint fix warning count violations #3680
Conversation
@TommyE123 Do you think the ansible lint test failure here is transient? |
Does it have to do with some env vars that change the logging format? |
Well I'm angry now with myself! I must have missed a scenario. However I think we need to use both mine and the existing regex but will check. Please don't merge and I will come back with a better more robust solution! I've also been looking at a better way to detect if ansible should be active in general. Thank you both for all your hard work today getting everything merged. 🙂 Tom |
@TommyE123 no problem haha ,thanks for your hard work :) |
After some testing, I've discovered that the current regex only works when Setting Given these findings, I'm closing this PR as the change doesn't work as initially intended. However, this does explain the behavior @alexanderbazhenoff encountered in #3446 (comment). I believe we can also close #3680 now, as this was the only outstanding issue there. Tom |
No prob, I haven't had any time for sure for the last few months either. May be I'll take a look into ansible-lint output also once I get back to refactoring my four roles. Thanks for trying anyway. |
Fixes #3446
Currently the count for the warning violations regex errors and doesn’t display the correct count.
Proposed Changes
Changed the regex to count the violations that
ansible-lint
outputs.Testing
I’ve checked this on both
Github
andAzure pipelines
using 2 different repositories and the results are as expected.Before:
After:
If there are any issues or concerns, please let me know, and I will address them promptly.
Thank you for reviewing this PR and I look forward to your feedback.
Tom