Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py usage with pyproject.toml using hatch #3893

Merged
merged 27 commits into from
Aug 26, 2024

Conversation

echoix
Copy link
Collaborator

@echoix echoix commented Aug 18, 2024

Fixes #

Proposed Changes

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@echoix
Copy link
Collaborator Author

echoix commented Aug 18, 2024

Missing changelog entry. And wait for CI in my fork to finish so dev-linters will run before

@echoix
Copy link
Collaborator Author

echoix commented Aug 18, 2024

My changelog entry:

Replace usage of setup.py with a pyproject.toml package install, by @echoix in #3893

@nvuillam
Copy link
Member

@echoix is the PR ready ? :)

@echoix
Copy link
Collaborator Author

echoix commented Aug 26, 2024

It was last weekend, I added the changelog back. Either run the build command inside this or after. (But it doesn't really matter if there weren't any merge conflicts when you updated from main, it's at different places of the Dockerfiles)

@echoix
Copy link
Collaborator Author

echoix commented Aug 26, 2024

Recently uv finally announced their new functionality that allows to manage the complete project, run scripts, being the backend to build. + docs website. It was in the last week. It takes the same place as hatchling, and setuptools. If I would have known that is was coming, maybe I would've tried it to be all-on uv. But I never used it before, and almost no info to help exist appart their new docs website.

@nvuillam nvuillam merged commit a60fe7b into oxsecurity:main Aug 26, 2024
6 checks passed
@nvuillam
Copy link
Member

@echoix we'll see in the next auto-update-linters job if it's all running well ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants