Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-Commerce Scraper API & Code Restructure #4

Merged
merged 36 commits into from
Jan 26, 2024
Merged

Conversation

ahmd-alli
Copy link
Contributor

@ahmd-alli ahmd-alli commented Jan 10, 2024

  • Added ecommerce/ sources
  • Added separate resp files for serp/ and internal/

Base automatically changed from sdk-work to master January 12, 2024 07:48
@ahmd-alli ahmd-alli changed the base branch from master to sdk-restructure January 16, 2024 06:16
Base automatically changed from sdk-restructure to master January 17, 2024 03:43
@ahmd-alli
Copy link
Contributor Author

@maaz-munir Brother, I have updated the code structure here too. Can you please take a look at it ?

@maaz-munir maaz-munir self-requested a review January 26, 2024 06:32
@ahmd-alli ahmd-alli requested review from UmanShahzad and removed request for maaz-munir January 26, 2024 06:58
@ahmd-alli ahmd-alli changed the title [WIP] E-Commerce Scraper API E-Commerce Scraper API & Code Restructure Jan 26, 2024
Copy link
Contributor

@UmanShahzad UmanShahzad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @Ryouku @denis-zyk @efgh5678 , refactor is done and ecommerce SERP APIs are also done. This should be good to go for an MVP launch to test the waters with real users.

@UmanShahzad UmanShahzad merged commit 26e9869 into master Jan 26, 2024
@UmanShahzad UmanShahzad deleted the ecommerce-scraper-api branch January 26, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants