Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue/39 Uncaught TypeError: Cannot read property 'nodeName' of … #65

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: issue/39 Uncaught TypeError: Cannot read property 'nodeName' of … #65

wants to merge 4 commits into from

Conversation

futurist
Copy link

@futurist futurist commented Dec 5, 2021

this PR should fix: #39

The logic retuned:

  1. When firstElementChild is empty, the returned value should be checked against null
  2. When it's not INPUT or TEXTAREA, then fallback to range.getBoundingClientRect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'nodeName' of null
1 participant
@futurist