Upgrade to Kafka 3.8.0 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-wall
changed the title
k-wall
commented
Jul 17, 2024
| assertThat(properties).containsEntry(KafkaConfig.AdvertisedListenersProp(), "PLAINTEXT://:9092,BROKER://:9093"); | ||
| assertThat(properties).containsEntry(KafkaConfig.EarlyStartListenersProp(), "BROKER,CONTROLLER"); | ||
| assertThat(properties).containsEntry(KafkaConfig.ListenerSecurityProtocolMapProp(), "BROKER:PLAINTEXT,CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT"); | ||
| assertThat(properties).containsEntry("broker.id", "1"); |
There was a problem hiding this comment.
With constants now coming from so many different places, a mistake would be easy. Testing against the string gives us confidence that the production code is achieving the right config.
Signed-off-by: kwall <kwall@apache.org>
why: KAFKA-16207 removed symbol NON_ROUTABLE_ADDRESS so the reason for the substitution goes away Signed-off-by: kwall <kwall@apache.org>
|
@robobario could you review this too? |
|
Apache Kafka RC3 has several binding votes already, so in preparation for the Apache Kafka 3.8.0 release, I've undrafted this PR. |
Remove staging repo config.
|
@ozangunalp if you have chance, could you review please? |
|
@k-wall yes i have it on my list. But I'll need a couple of days. |
|
It looks good to me. I pushed a small change to pull the remaining config names. |
|
thanks @ozangunalp, could you add an approval so I can merge this. |
ozangunalp
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to get compatibility with Kafka 3.8.0