Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular expressions support #305

Merged

Conversation

aerfus
Copy link
Contributor

@aerfus aerfus commented Feb 18, 2024

Regular expressions support for single column.

Implementation details:

  • a new expression filed is added to ExcelCellName annotation
  • value parameter is left as-is as it would cause performance downtime for existing usages

Resolved #304

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 93.43%. Comparing base (a43533d) to head (29612d6).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
.../java/com/poiji/bind/mapping/HSSFUnmarshaller.java 92.59% 3 Missing and 1 partial ⚠️
...main/java/com/poiji/bind/mapping/PoijiHandler.java 93.10% 1 Missing and 1 partial ⚠️
src/main/java/com/poiji/util/ReflectUtil.java 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #305      +/-   ##
============================================
- Coverage     93.61%   93.43%   -0.19%     
- Complexity      445      461      +16     
============================================
  Files            44       44              
  Lines          1222     1294      +72     
  Branches        153      161       +8     
============================================
+ Hits           1144     1209      +65     
- Misses           41       47       +6     
- Partials         37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aerfus aerfus force-pushed the feat/304-regular-expression-support branch from 6578e53 to 211e976 Compare February 18, 2024 06:41
To make extensions less difficult

Refs: 304
@aerfus aerfus force-pushed the feat/304-regular-expression-support branch from 7c1099f to cebe9a0 Compare February 20, 2024 13:15
@aerfus aerfus force-pushed the feat/304-regular-expression-support branch from cebe9a0 to 29612d6 Compare February 20, 2024 13:17
@aerfus
Copy link
Contributor Author

aerfus commented Feb 20, 2024

Hi @ozlerhakan ,

I've finished with the changes.
Could you please review?

P.S. I'm don't know why indexToTitle uses @ in values of duplicate columns,
so I left it as-is.

@ozlerhakan
Copy link
Owner

Hi @aerfus ,

Thank you for working on that! I'll review it over the weekend!

@ozlerhakan ozlerhakan merged commit 29612d6 into ozlerhakan:master Feb 25, 2024
3 of 5 checks passed
@ozlerhakan
Copy link
Owner

Thanks @aerfus ! Could you please also create a PR to explain the new feature in the README?

@aerfus
Copy link
Contributor Author

aerfus commented Feb 25, 2024

Thanks @aerfus ! Could you please also create a PR to explain the new feature in the README?

Hi @ozlerhakan!
Sure, let me proceed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regex Expression support for column name(s)
3 participants