fix(server): type errors failing production build

p-98 · Jun 5, 2024 · b045103 · b045103
1 parent e8773b6
commit b045103
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/server/src/modules/electoralOffice.ts b/server/src/modules/electoralOffice.ts
@@ -137,7 +137,7 @@ export async function createVote(
     });
 }
 
-export async function deleteVote(ctx: IAppContext, id: string) {
+export async function deleteVote(ctx: IAppContext, id: string): Promise<void> {
     const { knex, session } = ctx;
     assertRole(ctx, session.userSignature, "POLITICS");
     return knex.transaction(async (trx) => {

diff --git a/server/src/util/misc.ts b/server/src/util/misc.ts
@@ -109,7 +109,7 @@ export const compute = <T>(f: () => T): T => f();
 /** Apply a function if value is not null */
 export const mapNullableC =
     <T, U>(f: (_x: T) => U) =>
-    (x: TNullable<T>) =>
+    (x: TNullable<T>): TNullable<U> =>
         isNull(x) ? null : f(x);
 
 /* * Haskell-style logging functions * */

diff --git a/types.ts b/types.ts
@@ -213,7 +213,7 @@ export function inOperator<K extends PropertyKey, O>(
     key: K,
     obj: O
 ): obj is O & Record<K, unknown> {
-    return key in obj;
+    return typeof obj === "object" && obj !== null && key in obj;
 }
 
 export function checkPropertyType<K extends PropertyKey, O, T>(