Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#62 accept ttl of -1 from redis-py 3.x #64

Merged
merged 1 commit into from
Apr 15, 2021
Merged

#62 accept ttl of -1 from redis-py 3.x #64

merged 1 commit into from
Apr 15, 2021

Conversation

hnimminh
Copy link
Contributor

@hnimminh hnimminh commented Mar 4, 2021

in dump rdb data of redisdl, TTL/PTTL = -1 was not handled. This commit add handling for redis return -1 value.

@hnimminh hnimminh mentioned this pull request Mar 4, 2021
Closed
@hnimminh
Copy link
Contributor Author

hnimminh commented Mar 4, 2021

@p can take a time to review this pull request. thanks

@p
Copy link
Owner

p commented Mar 17, 2021

Are you using redis-py 3.x?

@hnimminh
Copy link
Contributor Author

yup, I used redis-py==3.5.2,

@p p changed the title #62 fix the ttl for dumps #62 accept ttl of -1 from redis-py 3.x Apr 15, 2021
@p p merged commit d5affcb into p:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hnimminh @p