Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore blank strings from history.add #50

Merged
merged 2 commits into from
Sep 30, 2019
Merged

ignore blank strings from history.add #50

merged 2 commits into from
Sep 30, 2019

Conversation

thewisenerd
Copy link
Contributor

No description provided.

p0deje
p0deje reviewed Sep 29, 2019
View reviewed changes
Copy link
Owner

@p0deje p0deje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but can you please address few comments I left.

Maccy/History.swift Outdated Show resolved Hide resolved
Maccy/History.swift Outdated Show resolved Hide resolved
Maccy/History.swift Outdated Show resolved Hide resolved
@p0deje p0deje added the enhancement New feature or request label Sep 29, 2019
@thewisenerd
Copy link
Contributor Author

resolved

@p0deje p0deje merged commit 1adb1a1 into p0deje:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0deje p0deje p0deje left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thewisenerd @p0deje