Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the reading of epub to use the semantic structure of the epub file and not only as chunks of text #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hlyl
Copy link

@hlyl hlyl commented Sep 19, 2024

Problem:
Today you only read the text out of the epub file.
Solution:
we have updated the code to read and retain the structure of the epub file in beutiful soup so it can be used to change e.g the pitch of voice when reading the text.
Example:
We implemented a example of changing the pitch of voice when reading a Blockquote section of the test book.

We tested this with a text document that is also included in the code.

If you like this we will continue working in this direction.

Copy link
Collaborator

@Bryksin Bryksin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like it! It looks way cleaner!
However, it feels like openai_tts_provider and piper were left unmodified to benefit from those changes?

@hlyl
Copy link
Author

hlyl commented Sep 30, 2024

We spent ½ day on making the POC, and was focused on the implementation on Edge as this is what I use but would be willing to spend more time to expand the POC to be more clean, tested and look at the other TTS engines.
Should we continue to work in this direction ?

@Bryksin
Copy link
Collaborator

Bryksin commented Sep 30, 2024

Oh yes! Please! We will definitely accept the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants