proxy: Reuse the existing slot ID mapping after fork #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
f6cbe4c to
88a9f67
Compare
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
88a9f67 to
f176677
Compare
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
f176677 to
b42f775
Compare
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
b42f775 to
8f75b97
Compare
ueno
changed the title
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
8f75b97 to
9401e55
Compare
While the proxy module reassigns slot IDs in C_Initialize(), some applications assume that valid slot IDs should never change across multiple calls to C_Initialize(). This patch mitigates this by preserving the slot IDs, if they are known to the proxy module.
ueno
force-pushed
the
wip/dueno/reuse-slot-id
branch
from
9401e55 to
fd7cd2a
Compare
|
I talked with @rjrelyea about this and it seems that the remapping is really a responsibility of a module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the proxy module reassigns slot IDs in
C_Initialize(), some applications assume that valid slot IDs should never change across multiple calls toC_Initialize(). This patch mitigates this by preserving the slot IDs, if they are known to the proxy module.Note that this change is experimental. @ansasaki, @nmav this is what I was talking yesterday.