test: Take advantage of TAP test driver #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmav
reviewed
Mar 27, 2018
| @@ -0,0 +1,70 @@ | |||
| /* | |||
| * Copyright (c) 2012 Stefan Walter | |||
There was a problem hiding this comment.
I think it should be red hat here.
nmav
reviewed
Mar 27, 2018
p11-kit/mock-module-ep5.c
Outdated
| * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH | ||
| * DAMAGE. | ||
| * | ||
| * Author: Stef Walter <stef@thewalter.net> |
There was a problem hiding this comment.
Author info seems inaccurate.
nmav
reviewed
Mar 27, 2018
| assert_todo ("not implemented", "CKR_CRYPTOKI_ALREADY_INITIALIZED handling"); | ||
| } | ||
| finalize_and_free_modules (modules); | ||
| } |
ueno
force-pushed
the
wip/dueno/tap
branch
2 times, most recently
from
a37a936 to
a3a8b82
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes test output finer grained and also enables to write skipped/expected-to-fail tests in a single test case.