-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anchor: Prefer persistent format when storing anchor #329
Conversation
4d4ff68
to
0505f44
Compare
cc @t184256 |
bb0dedf
to
0714723
Compare
Is 0714723 related to the change in question? If yes, how? |
0714723 is for a CI failure in mingw64 cross build. Since the other one (autotools) is still failing, I'll split it to a separate PR. |
0714723
to
1d79c02
Compare
I can't confirm that the test is being called. I've placed an assertion that should've failed and tried both |
It needs to be called from the autotools build, something like: ./autogen.sh --without-systemd --without-bash-completion --with-trust-paths=$PWD/ca-trust-source --prefix=$PWD/prefix
make
make install
mkdir ca-trust-store
make installcheck Unfortunately, the autotools CI job is currently failing because of the reasons I haven't investigated yet. |
This should be fixed with #330 (the reason was that docker on the base system is not compatible with Fedora 33). |
When a new certificate is stored with "trust anchor --store" from a .p11-kit file, the command treated it as a PEM file, while it should preserve extra fields in the file.
1d79c02
to
aeac5a2
Compare
Can confirm that the test now passes in CI, and that it fails with |
Thanks for checking!
This is a bit difficult because we would need to tweak the paths embedded in the library. |
When a new certificate is stored with "trust anchor --store" from a .p11-kit file, the command treated it as a PEM file, while it should
preserve extra fields in the file.