Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anchor: Prefer persistent format when storing anchor #329

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

ueno
Copy link
Member

@ueno ueno commented Nov 6, 2020

When a new certificate is stored with "trust anchor --store" from a .p11-kit file, the command treated it as a PEM file, while it should
preserve extra fields in the file.

@ueno ueno force-pushed the wip/dueno/anchor-persist branch from 4d4ff68 to 0505f44 Compare November 6, 2020 17:06
@ueno
Copy link
Member Author

ueno commented Nov 6, 2020

cc @t184256

@ueno ueno added the bug label Nov 6, 2020
@ueno ueno force-pushed the wip/dueno/anchor-persist branch from bb0dedf to 0714723 Compare November 9, 2020 14:54
@t184256
Copy link
Contributor

t184256 commented Nov 9, 2020

Is 0714723 related to the change in question? If yes, how?

@ueno
Copy link
Member Author

ueno commented Nov 9, 2020

0714723 is for a CI failure in mingw64 cross build. Since the other one (autotools) is still failing, I'll split it to a separate PR.

@ueno ueno force-pushed the wip/dueno/anchor-persist branch from 0714723 to 1d79c02 Compare November 9, 2020 16:51
@t184256
Copy link
Contributor

t184256 commented Nov 9, 2020

I can't confirm that the test is being called. I've placed an assertion that should've failed and tried both ninja make or make check, both passed. Could you please confirm that it is invoked?

@ueno
Copy link
Member Author

ueno commented Nov 9, 2020

It needs to be called from the autotools build, something like:

./autogen.sh --without-systemd --without-bash-completion --with-trust-paths=$PWD/ca-trust-source --prefix=$PWD/prefix
make
make install
mkdir ca-trust-store
make installcheck

Unfortunately, the autotools CI job is currently failing because of the reasons I haven't investigated yet.

@ueno
Copy link
Member Author

ueno commented Nov 29, 2020

Unfortunately, the autotools CI job is currently failing because of the reasons I haven't investigated yet.

This should be fixed with #330 (the reason was that docker on the base system is not compatible with Fedora 33).

When a new certificate is stored with "trust anchor --store" from a
.p11-kit file, the command treated it as a PEM file, while it should
preserve extra fields in the file.
@ueno ueno force-pushed the wip/dueno/anchor-persist branch from 1d79c02 to aeac5a2 Compare December 2, 2020 13:04
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 81.193% when pulling aeac5a2 on ueno:wip/dueno/anchor-persist into bd7702f on p11-glue:master.

@t184256
Copy link
Contributor

t184256 commented Dec 2, 2020

Can confirm that the test now passes in CI, and that it fails with test-extract.sh: nss-server-distrust-after is not preserved if the change is reverted. Would be ideal if meson builds also triggered this, but that's probably a separate issue.

@ueno ueno merged commit 7e7f5b1 into p11-glue:master Dec 3, 2020
@ueno
Copy link
Member Author

ueno commented Dec 3, 2020

Thanks for checking!

Would be ideal if meson builds also triggered this, but that's probably a separate issue.

This is a bit difficult because we would need to tweak the paths embedded in the library.

@ueno ueno added this to the 0.23.22 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants